[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Review of Debian package pystray



hi Claudius,

took a look at the pystray package up for sponsorship in the Python
team. Overall it's in really good shape, still a few comments left
though:

* control: the long description is really short and mentions neither
supported environment nor any other pystray features.

* tests:
 + please loop over py3versions -s rather than -r;
 + both tests have the same test-name;
 + the upstream testsuite autopkgtest doesn't actually run any tests
   according to ci logs [1];
 + for the upstream testsuite, you want to copy the test files to the
   $AUTOPKGTEST_TMP dir and run from there, to avoid testing the
   extracted sources rather than the installed package;
 + keeping the test commands/script in a separate file (rather than
   d/tests/control) tends to greatly increase readability for all but
   the smallest and most trivial autopkgtests.


[1]https://salsa.debian.org/python-team/packages/pystray/-/jobs/3596337#L411

Attachment: pgpN8ySRYH0iX.pgp
Description: OpenPGP digital signature


Reply to: