[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: py7zr-related python packages was updated



Hi Yokota,

Étienne Mollier, on 2024-04-30:
> yokota, on 2024-04-30:
> > I was uploaded fixes as you suggested.
> > Please upload them.
[…]
> > * https://salsa.debian.org/python-team/packages/python-brotlicffi

I proceeded to a couple of minor changes to debian/changelog.
Good catch with the MIT/Expat licensing terms that weren't well
attributed initially!  The change was missing from the changelog
though.

If that helps, I found it beneficial in my workflow to template
my d/changelog file using my git messages with the command:

	$ gbp dch --full

Documentation is available in the gbp-dch(1) manual page.  Note
that it may require some getting used to, as the new entries get
appended starting from the oldest commit that did not touch the
d/changelog file, and may behave unexpectedly if mixed with
other tools like routine-update or lintian-brush, that write
changelog entries on a per-commit basis.

The package looked otherwise in good shape in my opinion, I thus
proceeded to an upload.

For your next uploads, I see the MIT/Expat license is written
twice in the d/copyright file.  I thought you might want to
deduplicate it, see abpoa's[1] for an example.

[1]: https://salsa.debian.org/med-team/abpoa/-/blob/master/debian/copyright?ref_type=heads

> > * https://salsa.debian.org/python-team/packages/python-inflate64
> > * https://salsa.debian.org/python-team/packages/python-pyppmd

I uploaded python-inflate64 and python-pyppmd after a few
changes to the debian/changelog file.  I don't have much to add
that I hadn't mentioned yesterday about the previous upload.

I kind of question whether I should have mentioned Source-only
upload entries in my previous email.  This entry is generally
not needed.  It is useful only when a source package upload is
required without any changes to the packaging; the idea is thus
to pad the changelog entry with something as it would be
otherwise empty.  I'm sorry I may not have been very clear
introducing this concept in my early message, you probably won't
have to worry about it.

> > I also uploads other py7zr-related packages to add your suggested fixes.
> > Please also upload them.
> > 
> > * https://salsa.debian.org/python-team/packages/python-multivolumefile
> > * https://salsa.debian.org/python-team/packages/python-pyzstd

Both uploaded, checkout the d/changelog fixup, there is not much
to add otherwise.  Both packages were already in good shape.

Thank you for your contributions!
Have a nice day,  :)
-- 
  .''`.  Étienne Mollier <emollier@debian.org>
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/0, please excuse my verbosity
   `-

Attachment: signature.asc
Description: PGP signature


Reply to: