[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#829247: vsftpd: initscript stop and restart actions should ensure the process has stopped before returning



Source: vsftpd
Version: 3.0.3-4
Tags: patch
User: lamby@debian.org
Usertags: initscript-actions

vsftpd's initscript does not check whether the process has actually
terminated before returning successfully.

This can result in a non-deterministic race condition where resources
that are required by the corresponding "start" action (eg. TCP ports,
exclusive filesystem locks, etc.) are not yet available to the new
instance because the older process is still releasing them in the
background.

This then results in the new process failing to start which is often
hidden from the sysadmin for some time unless a monitoring system is
in use.

For the same/parallel reasons, the stop and restart actions should return
a non-zero exit code if the daemon failed to stop. Note that adding
"sleep" calls merely masks the problem and is thus not a valid fix.

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Attachment: vsftpd.diff.txt
Description: Binary data


Reply to: