--- Begin Message ---
- To: Debian Bug Tracking System <maintonly@bugs.debian.org>
- Subject: pdnsd: Incorrect warning string
- From: Rupert Swarbrick <rswarbrick@gmail.com>
- Date: Mon, 25 Jun 2012 09:57:52 +0100
- Message-id: <87395j6a5r.fsf@hake.rswarbrick.dnsalias.com>
Package: pdnsd
Version: 1.2.8-par-2.2
Severity: minor
Hi,
Small English grammar error in check_pid () in /etc/init.d/pdnsd. The
line
log_warning_msg "pid file is exist in $PIDFILE, stop $pdnsd it or restart $pdnsd"
should probably be
log_warning_msg "pid file exists at $PIDFILE, stop $pdnsd it or restart $pdnsd"
or something similar.
Cheers,
Rupert
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (101, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 3.3.0+ (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages pdnsd depends on:
ii adduser 3.113+nmu3
ii debconf [debconf-2.0] 1.5.44
ii libc6 2.13-33
Versions of packages pdnsd recommends:
ii resolvconf 1.67
pdnsd suggests no packages.
-- Configuration Files:
/etc/NetworkManager/dispatcher.d/002_NetMan_pdnsd [Errno 2] No such file or directory: u'/etc/NetworkManager/dispatcher.d/002_NetMan_pdnsd'
/etc/default/pdnsd changed:
START_DAEMON=yes
AUTO_MODE=resolvconf
START_OPTIONS=
/etc/init.d/pdnsd changed:
NAME="pdnsd"
DESC="proxy DNS server"
DAEMON="/usr/sbin/pdnsd"
PIDFILE="/var/run/pdnsd.pid"
CACHE="/var/cache/pdnsd/pdnsd.cache"
test -x $DAEMON || exit 0
test -f "/etc/default/$NAME" || exit 0
. "/etc/default/$NAME"
if test -n "$AUTO_MODE" && test -f /usr/share/pdnsd/pdnsd-$AUTO_MODE.conf
then
START_OPTIONS="${START_OPTIONS} -c /usr/share/pdnsd/pdnsd-$AUTO_MODE.conf"
fi
. /lib/lsb/init-functions
test -f /etc/default/rcS || exit 0
is_yes() {
case "$1" in
[Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|1) return 0;;
*) return 1;
esac
}
log_end_msg2 () {
log_end_msg "$@"
test $1 -eq 0 || exit 1
}
gen_cache()
{
if ! test -f "$CACHE"; then
mkdir -p `dirname $CACHE`
dd if=/dev/zero of="$CACHE" bs=1 count=4 2> /dev/null
chown -R pdnsd.proxy /var/cache/pdnsd
fi
}
check_pid()
{
if test -f "$PIDFILE"; then
log_warning_msg "pid file is exist in $PIDFILE, stop $pdnsd it or restart $pdnsd"
exit 1
fi
}
start_resolvconf()
{
test -x /sbin/resolvconf || return
for f in `seq 1 60`; do
sleep 0.1
if pdnsd-ctl status >/dev/null 2>&1; then
break
fi
done
if pdnsd-ctl status | grep -q resolvconf; then
server=$(pdnsd-ctl status|sed -ne '/^Global:$/,/^Server.*:$/s/.*Server ip.*: \(.*\)$/\1/p')
case "$server" in
"") ;;
0.0.0.0) echo "nameserver 127.0.0.1" | /sbin/resolvconf -a "lo.$NAME";;
*) echo "nameserver $server" | /sbin/resolvconf -a "lo.$NAME";;
esac
fi
}
stop_resolvconf()
{
if [ -x /sbin/resolvconf ] ; then
/sbin/resolvconf -d "lo.$NAME"
fi
}
pdnsd_start()
{
if is_yes "$START_DAEMON"; then
check_pid
log_begin_msg "Starting $NAME"
start-stop-daemon --oknodo --start --quiet --pidfile "$PIDFILE" \
--exec "$DAEMON" -- --daemon -p "$PIDFILE" $START_OPTIONS
log_end_msg2 $?
start_resolvconf
else
log_warning_msg "Not starting $NAME (disabled in /etc/default/$NAME)"
fi
}
pdnsd_stop()
{
log_begin_msg "Stopping $NAME"
start-stop-daemon --oknodo --stop --quiet --user pdnsd --retry=TERM/3/KILL/3 --pidfile "$PIDFILE" --name "$NAME"
start-stop-daemon --oknodo --stop --quiet --user pdnsd --retry=0/3/KILL/3 --exec "$DAEMON" > /dev/null
log_end_msg2 $?
rm -f "$PIDFILE"
stop_resolvconf
}
pdnsd_status()
{
if status_of_proc $DAEMON $NAME; then
/usr/sbin/pdnsd-ctl status
fi
}
case "$1" in
start)
gen_cache
pdnsd_start
;;
stop)
pdnsd_stop
;;
status)
pdnsd_status
;;
restart|force-reload)
pdnsd_stop
pdnsd_start
;;
*)
echo "Usage: /etc/init.d/$NAME {start|stop|restart|force-reload|status}" >&2
exit 1
;;
esac
exit 0
/etc/pdnsd.conf changed:
// See /usr/share/pdnsd
-- debconf information:
* pdnsd/conf: Use resolvconf
--- End Message ---