[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#915170: nvi: reproducible build (usrmerge): embeds path of sh found via PATH



Source: nvi
Version: 1.81.6-13
Severity: normal
Tags: patch
User: md@linux.it
Usertags: usrmerge

Dear Maintainer,

According to reproducible build tests nvi gets built differently
on a merged-usr system vs a non-merged system.

The package embeds the full path of sh. Since PATH defaults to
/usr/bin before /bin, the first will be used on a usrmerged system
where they're both essentially the same thing, but /usr/bin/sh does
not exist on non-merged systems.

The attached patch passes `vi_cv_path_shell=/bin/sh` to explicitly set
the path.

Regards,
Ansgar

diff -Nru nvi-1.81.6/debian/changelog nvi-1.81.6/debian/changelog
--- nvi-1.81.6/debian/changelog	2016-12-31 05:10:57.000000000 +0100
+++ nvi-1.81.6/debian/changelog	2018-12-01 13:41:09.000000000 +0100
@@ -1,3 +1,10 @@
+nvi (1.81.6-14) UNRELEASED; urgency=medium
+
+  * Explicit pass vi_cv_path_shell=/bin/sh to configure to make build
+    reproducible between merged-usr and non-merged-usr systems.
+
+ -- Ansgar Burchardt <ansgar@debian.org>  Sat, 01 Dec 2018 13:41:09 +0100
+
 nvi (1.81.6-13) unstable; urgency=medium
 
   * QA upload.
diff -Nru nvi-1.81.6/debian/rules nvi-1.81.6/debian/rules
--- nvi-1.81.6/debian/rules	2016-12-31 05:03:39.000000000 +0100
+++ nvi-1.81.6/debian/rules	2018-12-01 13:39:47.000000000 +0100
@@ -34,6 +34,7 @@
 	  ADDCPPFLAGS="$(CPPFLAGS)" \
 	  ADDLDFLAGS="$(LDFLAGS)" \
 	  ac_cv_path_vi_cv_path_sendmail=/usr/sbin/sendmail \
+	  vi_cv_path_shell=/bin/sh \
 	  vi_cv_revoke=no \
 	  ../dist/configure \
 		--build=$(DEB_BUILD_GNU_TYPE) \

Reply to: