[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#337876: marked as done (does not check properly for other launchtool with same tag)

Your message dated Mon, 25 Mar 2019 15:45:19 +0000
with message-id <[🔎] E1h8Rmp-0002Qc-BN@fasolo.debian.org>
and subject line Bug#925230: Removed package(s) from unstable
has caused the Debian Bug report #337876,
regarding does not check properly for other launchtool with same tag
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
337876: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=337876
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: launchtool
Version: 0.7-1
Severity: important
Tags: patch

The program does not check properly if another instance of launchtool
with the same tag is already started. This is due to an error in the
code, there is an "if" against a not-always-initialized variable.

On line 769 of src/launchtool.cc you find

    if (!op_no_pidfile && pidfile.is_active())

but op_no_pidfile is initialized (by libpopt) only when it is used and
to value 1. Given that the default is "-1" the expression !op_no_pidfile
is always false, which prevent to evaluate if other launchtools with
same tag are running.

To resolve just apply the attached diff to launchtool.cc

Beware that changing the default of op_no_pidfile is not feasible
because of the way GETBOOL works.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages launchtool depends on:
ii  libc6                         2.3.5-7    GNU C Library: Shared libraries an
ii  libgcc1                       1:4.0.2-3  GCC support library
ii  libpopt0                      1.7-5      lib for parsing cmdline parameters
ii  libstdc++5                    1:3.3.6-10 The GNU Standard C++ Library v3

launchtool recommends no packages.

-- no debconf information
-- 
Daniele                 JID: dan@jabber.linux.it (http://www.jabber.org)
and remember: respect is everything . . . . . . . . . . . free your mind

769c769,770
< 		if (!op_no_pidfile && pidfile.is_active())
---
>         //op_no_pidfile == -1 if --no-pidfile not specified
> 		if (op_no_pidfile == -1 && pidfile.is_active())

--- End Message ---
--- Begin Message --- 
Version: 0.8-2+rm

Dear submitter,

as the package launchtool has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/925230

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

--- End Message ---
Reply to: