Bug#930581: root-tail: buggy patch in debian package
Hi Marc,
I'm not the maintainer of the root-tail Debian package (it currently
has no maintainer, see https://bugs.debian.org/838406), but I'm
preparing a QA upload of the package to get 1.3 into Debian and the
package back to the current state of the art with regards to
packaging. Did that already once in the past.
Marc Lehmann wrote:
> while preparing release 1.3 of root-tail, I had a look at various
> distribution packages for potential bugfixes.
Noticed and appreciated it, thanks!
> While doing so, I found that debian has a patch that actually introduces a
> bug:
>
> config.h.patch Description: Use proper X fonts selector
>
> This replaces the correct value for the font pattern by an incorrect one
> (USE_FONT specified a font name, not a "X fonts selector", which, as far
> as I know, does not exist in X).
I must admit, I have no idea what could be right or wrong from a
theoretical side...
> While the effect is likely small on modenr systems, it nevertheless can
> lead to fonts being skipped that would normally be found when using the
> correct value, or even lead to no fonts being found at all when they would
> otherwise be found.
>
> Please consider removing the buggy patch.
... but since that patch fixed a crash (see
https://bugs.debian.org/298708), I'd be rather cautions with removing
it.
Will at least check if I can still reproduce the crash reported in
#298708 without that patch.
P.S.: root-tail fails to compile with GCC 9 due to --as-needed being
passed to the linker by default with GCC 9. Solved that in Debian by
patching the Makefile:
https://salsa.debian.org/debian/root-tail/blob/master/debian/patches/fix-linker-and-compiler-options.patch
Regards, Axel
--
,''`. | Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Reply to: