[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#667821: marked as done (eeepc-acpi-scripts: SHEngine notifications are not displayed)

Your message dated Wed, 01 Apr 2020 19:02:55 +0000
with message-id <E1jJidb-0003VK-Ao@fasolo.debian.org>
and subject line Bug#955195: Removed package(s) from unstable
has caused the Debian Bug report #667821,
regarding eeepc-acpi-scripts: SHEngine notifications are not displayed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
667821: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667821
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: eeepc-acpi-scripts
Version: 1.1.12
Severity: normal
Tags: patch

The notify-send fails to display some notifications due to missing whitespace escaping of arguments.
Attached patch fixes problem for SHEngine notifications.

Another solution is to add additional quotes around "$2" in line 38 of notify.sh like this 
 su $user -c notify-send\ -i\ $ICON\ \""$2"\"
but this sligthly changes overall behaviour as whole message goes into header.

-- System Information:
Debian Release: 6.0.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (193, 'testing'), (192, 'unstable'), (190, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to ru_RU.UTF-8)
Shell: /bin/sh linked to /bin/dash

diff --git a/acpilib/shengine.sh b/acpilib/shengine.sh
index 3763dec..39f7d77 100644
--- a/acpilib/shengine.sh
+++ b/acpilib/shengine.sh
@@ -66,11 +66,11 @@ handle_shengine() {
 	fi
 	if [ "$2" != '' ]; then return; fi
 	case $(get_shengine) in
-	    0) notify super_hybrid_engine 'S. H. Engine: Performance'; ;;
-	    1) notify super_hybrid_engine 'S. H. Engine: Standard'; ;;
-	    2) notify super_hybrid_engine 'S. H. Engine: Power-saving'; ;;
-	    255) notify super_hybrid_engine 'S. H. Engine: Automatic'; ;;
-	    *) notify error 'S. H. Engine unavailable'
+	    0) notify super_hybrid_engine 'S.\ H.\ Engine Performance'; ;;
+	    1) notify super_hybrid_engine 'S.\ H.\ Engine Standard'; ;;
+	    2) notify super_hybrid_engine 'S.\ H.\ Engine Power-saving'; ;;
+	    255) notify super_hybrid_engine 'S.\ H.\ Engine Automatic'; ;;
+	    *) notify error 'S.\ H.\ Engine unavailable'
 	esac
     else
 	notify error 'S. H. Engine unavailable'

--- End Message ---
--- Begin Message --- 
Version: 1.1.14+rm

Dear submitter,

as the package eeepc-acpi-scripts has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/955195

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

--- End Message ---
Reply to: