[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010414: libcec: reproducible builds: Embeds kernel version in libcec.so.*



Source: libcec
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: kernel
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The running kernel of the build machine is embedded in libcec.so.*:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/libcec.html

  ./usr/lib/x86_64-linux-gnu/libcec.so.6.0.2

  compiled·on·Linux-5.16.0-0.bpo.4-amd64·...·,·features:·P8_USB,·DRM,·P8_detect,·randr,·Exynos,·Linux,·AOCEC
vs.
  compiled·on·Linux-5.10.0-13-amd64·...·,·features:·P8_USB,·DRM,·P8_detect,·randr,·Exynos,·Linux,·AOCEC


The attached patch updates the existing reproducible builds patch to use
CMAKE_SYSTEM_NAME instead of CMAKE_SYSTEM (which includes the running
kernel version).

With this patch applied, libcec should build reproducibly on
tests.reproducible-builds.org when it migrates to bookworm/testing!


To get it building reproducibly in unstable and experimental where
differing build paths are tested, it also needs to apply one of the
standard fixes mentioned here:

  https://tests.reproducible-builds.org/debian/issues/cmake_rpath_contains_build_path_issue.html


I intend to fix both issues shortly.


Thanks for maintaining libcec!


live well,
  vagrant
From 9f3a10d425e92281399a669effdb76e24d02b6ae Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 30 Apr 2022 23:55:26 +0000
Subject: [PATCH 2/2] debian/patches: Update reproducible build patch to use
 Use CMAKE_SYSTEM_NAME instead of CMAKE_SYSTEM.

CMAKE_SYSTEM contains the running kernel version, which is likely to
be different between two builds.

https://tests.reproducible-builds.org/debian/issues/unstable/captures_kernel_version_via_CMAKE_SYSTEM_issue.html
---
 debian/patches/03_reproducible_build.patch | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/patches/03_reproducible_build.patch b/debian/patches/03_reproducible_build.patch
index 8d995bb..3611c36 100644
--- a/debian/patches/03_reproducible_build.patch
+++ b/debian/patches/03_reproducible_build.patch
@@ -1,6 +1,7 @@
 Description: Remove non-determinism from build process
  .
 Author: Balint Reczey <balint@balintreczey.hu>
+Updated: Vagrant Cascadian <vagrant@reproducible-builds.org>
 Forwarded: not-needed
 --- a/src/libcec/CMakeLists.txt
 +++ b/src/libcec/CMakeLists.txt
@@ -9,7 +10,7 @@ Forwarded: not-needed
  
  # platform and device specific
 -include(cmake/SetBuildInfo.cmake)
-+set(LIB_INFO "compiled on ${CMAKE_SYSTEM} ... ")
++set(LIB_INFO "compiled on ${CMAKE_SYSTEM_NAME} ... ")
  include(cmake/CheckPlatformSupport.cmake)
  
  ## create project groups
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature


Reply to: