[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1003144: marked as done (obexftp FTCBFS: multiple reasons)

Your message dated Mon, 11 Jul 2022 22:20:16 +0000
with message-id <E1oB1lI-000Bvn-Cc@fasolo.debian.org>
and subject line Bug#1003144: fixed in obexftp 0.24-7
has caused the Debian Bug report #1003144,
regarding obexftp FTCBFS: multiple reasons
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1003144: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003144
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: obexftp
Version: 0.24-6
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

obexftp fails to cross build from source. Most of the reasons come down
to language bindings. In order to make the problem manageable, I propose
adding support for the noperl and noruby build profiles. Those profiles
allow easy disabling of those language bindings. That's really needed
for ruby as the ruby packaging itself does not yet support cross
building in a sane way. So all we can support right now is cross
building with the noruby profile. For perl, exporting a PERL5LIB
pointing to the cross configs makes it work. Please consider applying
the attached patch.

Helmut

diff --minimal -Nru obexftp-0.24/debian/changelog obexftp-0.24/debian/changelog
--- obexftp-0.24/debian/changelog	2019-08-21 19:51:26.000000000 +0200
+++ obexftp-0.24/debian/changelog	2022-01-03 07:24:35.000000000 +0100
@@ -1,3 +1,13 @@
+obexftp (0.24-7) UNRELEASED; urgency=medium
+
+  * QA upload.
+  * Support build profiles noperl and noruby.
+  * Make obexftp cross build with just noruby:
+    + Add missing build dependency on perl-xs-dev.
+    + Export a PERL5LIB containing the cross config.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 03 Jan 2022 07:24:35 +0100
+
 obexftp (0.24-6) unstable; urgency=medium
 
   * QA upload.
diff --minimal -Nru obexftp-0.24/debian/control obexftp-0.24/debian/control
--- obexftp-0.24/debian/control	2019-08-21 19:51:17.000000000 +0200
+++ obexftp-0.24/debian/control	2022-01-03 07:24:35.000000000 +0100
@@ -7,11 +7,12 @@
  cmake,
  debhelper (>= 9),
  doxygen,
- gem2deb,
+ gem2deb <!noruby>,
  libbluetooth-dev,
  libopenobex2-dev,
+ perl-xs-dev <!noperl>,
  pkg-config,
- swig,
+ swig <!noperl> <!noruby>,
 Standards-Version: 3.9.7
 Homepage: http://triq.net/obex
 Vcs-Git: https://anonscm.debian.org/git/collab-maint/obexftp.git
@@ -140,6 +141,7 @@
 Package: ruby-obexftp
 Architecture: any
 Section: ruby
+Build-Profiles: <!noruby>
 Depends:
  libobexftp0 (= ${binary:Version}),
  ${misc:Depends},
@@ -163,6 +165,7 @@
 Package: libobexftp-perl
 Architecture: any
 Section: perl
+Build-Profiles: <!noperl>
 Depends:
  libobexftp0 (= ${binary:Version}),
  ${misc:Depends},
diff --minimal -Nru obexftp-0.24/debian/rules obexftp-0.24/debian/rules
--- obexftp-0.24/debian/rules	2019-08-21 19:51:26.000000000 +0200
+++ obexftp-0.24/debian/rules	2022-01-03 07:24:35.000000000 +0100
@@ -1,14 +1,26 @@
 #!/usr/bin/make -f
 
+include /usr/share/dpkg/architecture.mk
+
 export DH_VERBOSE=1
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 
+DOPACKAGES := $(shell dh_listpackages)
+
 ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
 	CFLAGS += -DOBEXFTP_DEBUG=5
 endif
 
+ifneq ($(filter libobexftp-perl,$(DOPACKAGES)),)
+PERL_VER := $(shell perl -MConfig -e 'print $$Config{version}')
+ifneq ($(DEB_BUILD_ARCH),$(DEB_HOST_ARCH))
+export PERL5LIB := /usr/lib/$(DEB_HOST_MULTIARCH)/perl/cross-config-$(PERL_VER)$(if $(PERL5LIB),:$(PERL5LIB))
+endif
 PERL_ARCHLIB := $(shell perl -MConfig -e 'print $$Config{vendorarch}')
+endif
+ifneq ($(filter ruby-obexftp,$(DOPACKAGES)),)
 RUBY_DEPENDS := -Vruby:Depends="lib$(firstword $(shell dh_ruby --print-supported))"
+endif
 
 %:
 	dh $@ --parallel
@@ -17,14 +29,19 @@
 	dh_gencontrol -- $(RUBY_DEPENDS)
 
 override_dh_auto_configure:
-	dh_auto_configure -- -DENABLE_PYTHON=OFF
+	dh_auto_configure -- \
+		-DENABLE_PERL=$(if $(filter libobexftp-perl,$(DOPACKAGES)),ON,OFF) \
+		-DENABLE_PYTHON=OFF \
+		-DENABLE_RUBY=$(if $(filter ruby-obexftp,$(DOPACKAGES)),ON,OFF)
 
 override_dh_auto_build:
 	dh_auto_build
 	doxygen
 
 override_dh_install:
+ifneq ($(filter libobexftp-perl,$(DOPACKAGES)),)
 	sed -e 's;@PERL_ARCHLIB@;$(PERL_ARCHLIB);g;' $(CURDIR)/debian/libobexftp-perl.install.in > $(CURDIR)/debian/libobexftp-perl.install
+endif
 	dh_install --fail-missing -X.la
 
 override_dh_installdocs:

--- End Message ---
--- Begin Message --- 
Source: obexftp
Source-Version: 0.24-7
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
obexftp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1003144@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated obexftp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 11 Jul 2022 14:45:14 -0700
Source: obexftp
Architecture: source
Version: 0.24-7
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 1003144
Changes:
 obexftp (0.24-7) unstable; urgency=medium
 .
   * QA upload.
 .
   [ Jelmer Vernooij ]
   * Migrate repository from alioth to salsa.
 .
   [ Helmut Grohne ]
   * Support build profiles noperl and noruby. (Closes: #1003144)
   * Make obexftp cross build with just noruby:
     + Add missing build dependency on perl-xs-dev.
     + Export a PERL5LIB containing the cross config.
 .
   [ Vagrant Cascadian ]
   * debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
     dh_auto_configure override.
   * Update to debhelper-compat 13.
Checksums-Sha1:
 83f827aa2b40436e2d8f597046be6057b4154ee6 1872 obexftp_0.24-7.dsc
 490f5a6d4bb13d41041a09e143d82f837b42f8e9 8916 obexftp_0.24-7.debian.tar.xz
 2135b0a435cbbc0187a401a742ca35278b38aa20 13294 obexftp_0.24-7_arm64.buildinfo
Checksums-Sha256:
 c1fa5e8f0e85a165071e6af8e4d1135f958eaf3126785868e56f7a51d5e099ee 1872 obexftp_0.24-7.dsc
 f93736a773685710994282190a4485ee18c41f42f40212d218d66f6e99729167 8916 obexftp_0.24-7.debian.tar.xz
 46564adad90b9bc8e0f3ff6a95b9c752429f587b7d54e24e72c51ea596583c9f 13294 obexftp_0.24-7_arm64.buildinfo
Files:
 a27159d7cff96dcf8393276f21958592 1872 comm optional obexftp_0.24-7.dsc
 a7d8126fd3b14d121a2f0b3e7a92ce48 8916 comm optional obexftp_0.24-7.debian.tar.xz
 ee8876e4609f05be2d4a44f6c717044d 13294 comm optional obexftp_0.24-7_arm64.buildinfo

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYsyd9SAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqjwxAQD2+lzayqwihgXG
9ZHwGUTKVsyXiFKxkeKqsV/2FObXbAEAjv+/UXPCqwy0gmh8SMmNlwZPyz3+VdR7
r/o4V9+tpwY=
=KmDl
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: