Package: librem-ec-acpi-dkms
Version: 0.9.1-4
Severity: grave
X-Debbugs-Cc: none, Asher Gordon <AsDaGo@posteo.net>
Dear Maintainer,
During a system upgrade, I noticed that there was an error upgrading the
Linux kernel. I was able to isolate the problem to the
librem-ec-acpi-dkms package. (Without this package, the brightness keys
on the Librem 14 do not work anymore after a suspend, and possibly other
issues too.) If I remove the package and install it again, I get the
following output:
Loading new librem_ec_acpi-0.9.1 DKMS files...
Building for 6.1.0-9-amd64 6.3.0-1-amd64
Building initial module for 6.1.0-9-amd64
Done.
librem_ec_acpi.ko:
Running module version sanity check.
- Original module
- No original module exists within this kernel
- Installation
- Installing to /lib/modules/6.1.0-9-amd64/updates/dkms/
depmod...
Building initial module for 6.3.0-1-amd64
Error! Bad return status for module build on kernel: 6.3.0-1-amd64 (x86_64)
Consult /var/lib/dkms/librem_ec_acpi/0.9.1/build/make.log for more information.
dpkg: error processing package librem-ec-acpi-dkms (--configure):
installed librem-ec-acpi-dkms package post-installation script subprocess returned error exit status 10
So it appears to build successfully against 6.1.0, but not 6.3.0. Here
is the contents of my /var/lib/dkms/librem_ec_acpi/0.9.1/build/make.log:
DKMS make.log for librem_ec_acpi-0.9.1 for kernel 6.3.0-1-amd64 (x86_64)
Fri Jun 23 01:16:58 AM EDT 2023
make: Entering directory '/usr/src/linux-headers-6.3.0-1-amd64'
CC [M] /var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.o
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:276:24: error: initialization of ‘int (*)(struct power_supply *, struct acpi_battery_hook *)’ from incompatible pointer type ‘int (*)(struct power_supply *)’ [-Werror=incompatible-pointer-types]
276 | .add_battery = librem_ec_battery_add,
| ^~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:276:24: note: (near initialization for ‘librem_ec_battery_hook.add_battery’)
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:277:27: error: initialization of ‘int (*)(struct power_supply *, struct acpi_battery_hook *)’ from incompatible pointer type ‘int (*)(struct power_supply *)’ [-Werror=incompatible-pointer-types]
277 | .remove_battery = librem_ec_battery_remove,
| ^~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:277:27: note: (near initialization for ‘librem_ec_battery_hook.remove_battery’)
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:773:27: error: initialization of ‘void (*)(struct acpi_device *)’ from incompatible pointer type ‘int (*)(struct acpi_device *)’ [-Werror=incompatible-pointer-types]
773 | .remove = librem_ec_remove,
| ^~~~~~~~~~~~~~~~
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:773:27: note: (near initialization for ‘librem_ec_driver.ops.remove’)
cc1: some warnings being treated as errors
make[1]: *** [/usr/src/linux-headers-6.3.0-1-common/scripts/Makefile.build:257: /var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.o] Error 1
make: *** [/usr/src/linux-headers-6.3.0-1-common/Makefile:2050: /var/lib/dkms/librem_ec_acpi/0.9.1/build] Error 2
make: Leaving directory '/usr/src/linux-headers-6.3.0-1-amd64'
I don't know much about kernel module development, but it looks like these errors are due to an API change in the new kernel version. This makes the package nonfunctional for Linux 6.3.0 (although it still works for 6.1.0, which I'm on now), thus the grave severity. Thanks, Asher -- System Information: Debian Release: trixie/sid APT prefers testing-debug APT policy: (500, 'testing-debug'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 6.1.0-9-amd64 (SMP w/12 CPU threads; PREEMPT) Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages librem-ec-acpi-dkms depends on: ii dkms 3.0.11-3 librem-ec-acpi-dkms recommends no packages. librem-ec-acpi-dkms suggests no packages. -- no debconf information
Attachment:
signature.asc
Description: PGP signature