[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1011499: marked as done (imagination: reproducible-builds: embedded build paths in various binaries)

Your message dated Sat, 22 Jul 2023 20:52:23 +0000
with message-id <E1qNJaR-005X67-Ph@fasolo.debian.org>
and subject line Bug#1011499: fixed in imagination 3.6-2
has caused the Debian Bug report #1011499,
regarding imagination: reproducible-builds: embedded build paths in various binaries
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1011499: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011499
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: imagination
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in various binaries:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/imagination.html

  /usr/bin/imagination

  /build/1st/imagination-3.6/src/imgcellrendereranim.c:63
  vs.
  /build/2/imagination-3.6/2nd/src/imgcellrendereranim.c:63

The attached patch fixes this by explicitly passing CFLAGS to a
dh_auto_build override in debian/rules, which includes the
-ffile-prefix-map argument used to avoid embedding build paths.


With this patch applied, imagination should build reproducibly on
tests.reproducible-builds.org!


live well,
  vagrant

From 01273015daccd5f14d9cf37b06909702f83da0a1 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 24 May 2022 00:17:51 +0000
Subject: [PATCH] debian/rules: Explicitly pass CFLAGS via dh_auto_build
 override.

---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index e2eadfe..e6cdda4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -14,3 +14,6 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 override_dh_gencontrol:
 	dh_gencontrol -pimagination -- $(SUBSTVARS)
 	dh_gencontrol -pimagination-common
+
+override_dh_auto_build:
+	dh_auto_build -- CFLAGS="$(CFLAGS)"
-- 
2.36.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: imagination
Source-Version: 3.6-2
Done: Joao Eriberto Mota Filho <eriberto@debian.org>

We believe that the bug you reported is fixed in the latest version of
imagination, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011499@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joao Eriberto Mota Filho <eriberto@debian.org> (supplier of updated imagination package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 22 Jul 2023 14:26:17 -0300
Source: imagination
Architecture: source
Version: 3.6-2
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Joao Eriberto Mota Filho <eriberto@debian.org>
Closes: 1011499
Changes:
 imagination (3.6-2) unstable; urgency=medium
 .
   * QA upload.
 .
   [ Joao Eriberto Mota Filho ]
   * debian/copyright:
       - Converted the last paragraphs of the GPL-2 and GPL-3 in comments.
       - Updated packaging copyright years.
   * debian/patches/020_disable-silent.patch: created to drop silent to allow
     blhc to check the hardening.
   * debian/rules: created target override_dh_auto_build to fix reproducible
     builds. Thanks to Vagrant Cascadian <vagrant@reproducible-builds.org>.
     (Closes: #1011499)
   * debian/source/lintian-overrides: created to override some false positives.
   * debian/tests/: removed because the CI test was using ampersand to run in
     background.
 .
   [ Debian Janitor ]
   * Update lintian override info format in d/imagination.lintian-overrides on
     line 2-15.
   * Set upstream metadata fields: Bug-Database.
   * Update standards version to 4.6.2, no changes needed.
   * Use secure URI in Homepage field.
Checksums-Sha1:
 ae8d35bb8d885a04b4f238f626fc7fc68f07720d 1993 imagination_3.6-2.dsc
 f14d9bbf6eacca3626aefa340818cf6877d731fe 9236 imagination_3.6-2.debian.tar.xz
 5aa348a5afb229f5f3fc88b84075bd17923a5623 16082 imagination_3.6-2_source.buildinfo
Checksums-Sha256:
 6c383f3c1d90b4f48ba9cf21e7fbc2015f64db1f3015496f9ee07ef2ecf51ad4 1993 imagination_3.6-2.dsc
 3484297e1b5691f56bcf30aa202cb406350d6b8e53f5fef6c1c36217cee6d6bf 9236 imagination_3.6-2.debian.tar.xz
 a63c39a09ebfd871b42b11e8319d9f4809d82758580754637804b27103fe9413 16082 imagination_3.6-2_source.buildinfo
Files:
 24c519b69bdf3921586517c41fbccc26 1993 video optional imagination_3.6-2.dsc
 b5c1c38e25f5a984687833139617e26b 9236 video optional imagination_3.6-2.debian.tar.xz
 fe9b6498517a2d54a4e7dba3e51eaa5b 16082 video optional imagination_3.6-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAmS8JDIACgkQ3mO5xwTr
6e9Peg/+PLT9aOyhylPJt1yOQMS2pfQEvWv11kTDHqjURHL17Whlfq8FkJdFA7CW
NY0/lNQU6gYx1xRPZmtNkBI4Bb89WErJKHbHAR5MU0Xq5xiWErX/jOfLF+sTr4GO
62RCjmVBCmMKNCyenGA2I1e/jCcJp79+lHFyUtRNwB7OgPBxjYmjBPI/OLZbZUlZ
EH1/xDo2bf8kkdtw0n9hfbSQJMmAYFjtiGabDItPyLYj51cvS4OqqN45J4GE/qwN
xbPRFDPaGbV2QXnazPDBDF6wrZsgwXaQsj3olbnbu/tMDnTd6IL+pChFEyEhHASr
fSVTdd/ZHbg54Sr1U6kpuLLi14cPT8nbCUo/tZXMh0uLYgqRUIasjR9s2bplhaEo
Xy+F9JdsvEO+Ee9aGgrCcgSPTFBpIYl1SMh9pVlskk/7sy+K1vYKbXqgeiyhnR2a
hwB63tAUg4dcfEtNPzUFsbwyd5MhyPd/QvMs0Rp+huAkBl6hPksPXYd6CK762yjg
NqswWO1o+qCnMmZaCA5AnkBCn7hDIDtyJ+ee1mSfnpDjaCbsEtm+DAD+4dX7FIe2
OTLCD/nEzmFXJvLDi/L4JkuyD3OhA6/yqXeJx6oowK8mJyd3MfdgEVoKAXfGQtBo
RR15UgZ7e2smY1FCAYfwpYNiU7r+pIi/6ygSlx40AT6bsvXUsTg=
=6um3
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: