Bug#1066462: dot-forward: FTBFS: control.c:65:41: error: implicit declaration of function ‘close’ [-Werror=implicit-function-declaration]
Source: dot-forward
Version: 1:0.71-6
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> ( cat warn-auto.sh; \
> echo CC=\'`head -1 conf-cc`\'; \
> echo LD=\'`head -1 conf-ld`\' \
> ) > auto-ccld.sh
> nroff -man dot-forward.1 > dot-forward.0
> cat auto-ccld.sh make-load.sh > make-load
> cat auto-ccld.sh find-systype.sh > find-systype
> cat auto-ccld.sh make-compile.sh > make-compile
> cat auto-ccld.sh make-makelib.sh > make-makelib
> chmod 755 make-load
> chmod 755 find-systype
> chmod 755 make-compile
> chmod 755 make-makelib
> ./find-systype > systype
> ( cat warn-auto.sh; ./make-load "`cat systype`" ) > load
> ( cat warn-auto.sh; ./make-compile "`cat systype`" ) > \
> compile
> ( cat warn-auto.sh; ./make-makelib "`cat systype`" ) > \
> makelib
> chmod 755 load
> chmod 755 makelib
> chmod 755 compile
> ./compile dot-forward.c
> ./compile control.c
> ( ( ./compile tryvfork.c && ./load tryvfork ) >/dev/null \
> 2>&1 \
> && cat fork.h2 || cat fork.h1 ) > fork.h
> ./compile auto-str.c
> ./compile substdio.c
> ./compile substdi.c
> ./compile substdo.c
> ./compile subfderr.c
> control.c: In function ‘control_readline’:
> control.c:65:41: error: implicit declaration of function ‘close’ [-Werror=implicit-function-declaration]
> 65 | if (getln(&ss,sa,&match,'\n') == -1) { close(fd); return -1; }
> | ^~~~~
> dot-forward.c: In function ‘run’:
> dot-forward.c:78:7: error: implicit declaration of function ‘pipe’ [-Werror=implicit-function-declaration]
> 78 | if (pipe(pi) == -1)
> | ^~~~
> dot-forward.c:81:19: error: implicit declaration of function ‘fork’ [-Werror=implicit-function-declaration]
> 81 | switch (child = fork()) {
> | ^~~~
> dot-forward.c:85:7: error: implicit declaration of function ‘close’ [-Werror=implicit-function-declaration]
> 85 | close(pi[1]);
> | ^~~~~
> dot-forward.c:86:11: error: implicit declaration of function ‘fd_move’ [-Werror=implicit-function-declaration]
> 86 | if (fd_move(0,pi[0]) == -1)
> | ^~~~~~~
> dot-forward.c:89:7: error: implicit declaration of function ‘sig_pipedefault’ [-Werror=implicit-function-declaration]
> 89 | sig_pipedefault();
> | ^~~~~~~~~~~~~~~
> dot-forward.c:90:7: error: implicit declaration of function ‘execv’ [-Werror=implicit-function-declaration]
> 90 | execv(*args,args);
> | ^~~~~
> auto-str.c:8:6: warning: conflicting types for built-in function ‘puts’; expected ‘int(const char *)’ [-Wbuiltin-declaration-mismatch]
> 8 | void puts(s)
> | ^~~~
> auto-str.c:4:1: note: ‘puts’ is declared in header ‘<stdio.h>’
> 3 | #include "exit.h"
> +++ |+#include <stdio.h>
> 4 |
> dot-forward.c: In function ‘readcontrols’:
> dot-forward.c:141:7: error: implicit declaration of function ‘chdir’ [-Werror=implicit-function-declaration]
> 141 | if (chdir(auto_qmail) == -1)
> | ^~~~~
> dot-forward.c:160:7: error: implicit declaration of function ‘fchdir’ [-Werror=implicit-function-declaration]
> 160 | if (fchdir(fddir) == -1)
> | ^~~~~~
> dot-forward.c: In function ‘gotaddr’:
> dot-forward.c:189:12: error: implicit declaration of function ‘case_diffb’ [-Werror=implicit-function-declaration]
> 189 | if (!case_diffb(address.s,address.len,user)) {
> | ^~~~~~~~~~
> dot-forward.c: In function ‘main’:
> dot-forward.c:389:3: error: implicit declaration of function ‘sig_pipeignore’ [-Werror=implicit-function-declaration]
> 389 | sig_pipeignore();
> | ^~~~~~~~~~~~~~
> rm -f tryvfork.o tryvfork
> ./compile substdio_copy.c
> ./compile error.c
> ./compile error_str.c
> ./compile str_len.c
> ./compile str_diffn.c
> ./compile byte_chr.c
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:75: control.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/dot-forward_0.71-6_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
Reply to: