Bug#1066533: libpcl1: FTBFS: cobench.c:125:44: error: implicit declaration of function ‘atoi’ [-Werror=implicit-function-declaration]
Source: libpcl1
Version: 1.12-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I.. -I./../include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o cothread.o cothread.c
> cobench.c: In function ‘run_test’:
> cobench.c:62:28: warning: format ‘%p’ expects argument of type ‘void *’, but argument 3 has type ‘pthread_t’ {aka ‘long unsigned int’} [-Wformat=]
> 62 | fprintf(stdout, "[%p] measuring co_create+co_delete performance ...\n",
> | ~^
> | |
> | void *
> | %ld
> 63 | pthread_self());
> | ~~~~~~~~~~~~~~
> | |
> | pthread_t {aka long unsigned int}
> cobench.c:78:28: warning: format ‘%p’ expects argument of type ‘void *’, but argument 3 has type ‘pthread_t’ {aka ‘long unsigned int’} [-Wformat=]
> 78 | fprintf(stdout, "[%p] %g usec\n", pthread_self(),
> | ~^ ~~~~~~~~~~~~~~
> | | |
> | void * pthread_t {aka long unsigned int}
> | %ld
> cobench.c:83:36: warning: format ‘%p’ expects argument of type ‘void *’, but argument 3 has type ‘pthread_t’ {aka ‘long unsigned int’} [-Wformat=]
> 83 | fprintf(stdout, "[%p] measuring switch performance ...\n",
> | ~^
> | |
> | void *
> | %ld
> 84 | pthread_self());
> | ~~~~~~~~~~~~~~
> | |
> | pthread_t {aka long unsigned int}
> cobench.c:96:36: warning: format ‘%p’ expects argument of type ‘void *’, but argument 3 has type ‘pthread_t’ {aka ‘long unsigned int’} [-Wformat=]
> 96 | fprintf(stdout, "[%p] %g usec\n", pthread_self(),
> | ~^ ~~~~~~~~~~~~~~
> | | |
> | void * pthread_t {aka long unsigned int}
> | %ld
> cobench.c: In function ‘main’:
> cobench.c:125:44: error: implicit declaration of function ‘atoi’ [-Werror=implicit-function-declaration]
> 125 | nthreads = atoi(argv[i]);
> | ^~~~
> cobench.c:131:39: error: implicit declaration of function ‘malloc’ [-Werror=implicit-function-declaration]
> 131 | thids = (pthread_t *) malloc(nthreads * sizeof(pthread_t));
> | ^~~~~~
> cobench.c:30:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’
> 29 | #include <pcl.h>
> +++ |+#include <stdlib.h>
> 30 |
> cobench.c:131:39: warning: incompatible implicit declaration of built-in function ‘malloc’ [-Wbuiltin-declaration-mismatch]
> 131 | thids = (pthread_t *) malloc(nthreads * sizeof(pthread_t));
> | ^~~~~~
> cobench.c:131:39: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’
> cothread.c: In function ‘main’:
> cothread.c:353:44: error: implicit declaration of function ‘atoi’ [-Werror=implicit-function-declaration]
> 353 | nthreads = atoi(argv[i]);
> | ^~~~
> cothread.c:359:39: error: implicit declaration of function ‘malloc’ [-Werror=implicit-function-declaration]
> 359 | thids = (pthread_t *) malloc(nthreads * sizeof(pthread_t));
> | ^~~~~~
> cothread.c:9:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’
> 8 | #include <pcl.h>
> +++ |+#include <stdlib.h>
> 9 |
> cothread.c:359:39: warning: incompatible implicit declaration of built-in function ‘malloc’ [-Wbuiltin-declaration-mismatch]
> 359 | thids = (pthread_t *) malloc(nthreads * sizeof(pthread_t));
> | ^~~~~~
> cothread.c:359:39: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’
> cothread.c: In function ‘test2’:
> cothread.c:308:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 308 | write(out, buf, n);
> | ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:371: cobench.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/libpcl1_1.12-2_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
Reply to: