Bug#1066567: easyh10: FTBFS: ucs2char_iconv.c:319:25: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
Source: easyh10
Version: 1.5-5
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> /bin/bash ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../include -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o ucs2char_iconv.lo ucs2char_iconv.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../include -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c ucs2char.c -fPIC -DPIC -o .libs/ucs2char.o
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../include -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c ucs2char_iconv.c -fPIC -DPIC -o .libs/ucs2char_iconv.o
> ucs2char.c: In function ‘print_ucs2’:
> ucs2char.c:284:28: warning: format ‘%c’ expects a matching ‘int’ argument [-Wformat=]
> 284 | fprintf(stderr, "0x%X %c ", *str);
> | ~^
> | |
> | int
> ucs2char_iconv.c: In function ‘print_ucs2’:
> ucs2char_iconv.c:57:28: warning: format ‘%c’ expects a matching ‘int’ argument [-Wformat=]
> 57 | fprintf(stderr, "0x%X %c ", *str);
> | ~^
> | |
> | int
> ucs2char_iconv.c: In function ‘iconv_convert’:
> ucs2char_iconv.c:169:27: warning: passing argument 2 of ‘iconv’ from incompatible pointer type [-Wincompatible-pointer-types]
> 169 | iconv(cd, (const char **)inbuf, &inbytesleft, (char **)outbuf, &outbytesleft);
> | ^~~~~~~~~~~~~~~~~~~~
> | |
> | const char **
> In file included from ucs2char_iconv.c:40:
> /usr/include/iconv.h:49:54: note: expected ‘char ** restrict’ but argument is of type ‘const char **’
> 49 | extern size_t iconv (iconv_t __cd, char **__restrict __inbuf,
> | ~~~~~~~~~~~~~~~~~~^~~~~~~
> ucs2char_iconv.c:177:50: warning: passing argument 2 of ‘iconv’ from incompatible pointer type [-Wincompatible-pointer-types]
> 177 | int iconvret = iconv(cd, (const char **)inbuf, &inbytesleft, &p, &outbytesleft);
> | ^~~~~~~~~~~~~~~~~~~~
> | |
> | const char **
> /usr/include/iconv.h:49:54: note: expected ‘char ** restrict’ but argument is of type ‘const char **’
> 49 | extern size_t iconv (iconv_t __cd, char **__restrict __inbuf,
> | ~~~~~~~~~~~~~~~~~~^~~~~~~
> ucs2char_iconv.c: In function ‘ucs2stat_is_exist’:
> ucs2char_iconv.c:319:25: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
> 319 | close(ret);
> | ^~~~~
> | pclose
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:387: ucs2char_iconv.lo] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/easyh10_1.5-5_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
Reply to: