Bug#1066614: splitvt: FTBFS: vt100.c:146:16: error: implicit declaration of function ‘check_attr’; did you mean ‘set_attr’? [-Werror=implicit-function-declaration]
Source: splitvt
Version: 1.6.6-15
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -DTERMCAP -DHAVE_UTHOST -DHAVE_TERMIOS_H -DHAVE_UNISTD_H -DSHELL=\"/bin/sh\" -DPTYCHAR=\"\" -DHEXDIGIT=\"\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o vtmouse.o vtmouse.c
> utmp.c: In function ‘addutmp’:
> utmp.c:219:21: warning: passing argument 1 of ‘time’ from incompatible pointer type [-Wincompatible-pointer-types]
> 219 | (void) time(&ut.ut_time);
> | ^
> | |
> | int32_t * {aka int *}
> In file included from utmp.c:11:
> /usr/include/time.h:76:29: note: expected ‘time_t *’ {aka ‘long int *’} but argument is of type ‘int32_t *’ {aka ‘int *’}
> 76 | extern time_t time (time_t *__timer) __THROW;
> | ~~~~~~~~^~~~~~~
> utmp.c: In function ‘delutmp’:
> utmp.c:248:21: warning: unused variable ‘ut’ [-Wunused-variable]
> 248 | struct utmp ut;
> | ^~
> utmp.c:298:24: warning: ignoring return value of ‘chown’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 298 | (void) chown(tty, 0, sb.st_gid);
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> vt100.c: In function ‘set_attr’:
> vt100.c:146:16: error: implicit declaration of function ‘check_attr’; did you mean ‘set_attr’? [-Werror=implicit-function-declaration]
> 146 | (void) check_attr(0, win->textattr, on);
> | ^~~~~~~~~~
> | set_attr
> terminal.c: In function ‘vt_insertchar’:
> terminal.c:427:6: warning: type of ‘numcols’ defaults to ‘int’ [-Wimplicit-int]
> 427 | void vt_insertchar(numcols)
> | ^~~~~~~~~~~~~
> vt100.c: In function ‘E_’:
> vt100.c:366:33: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 366 | write(*source, "\033[?6c", 5);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> vt100.c: In function ‘E_brac’:
> vt100.c:648:41: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 648 | write(*source, "\033[0n", 4);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> vt100.c:654:41: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 654 | write(*source, reply, strlen(reply));
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> vt100.c:660:33: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 660 | write(*source, "\033[?6c", 5);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> vttest.c: In function ‘vttest’:
> vttest.c:106:9: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 106 | write(fd,"\033[c", 3); /* Vt100 test: ESC [ c */
> | ^~~~~~~~~~~~~~~~~~~~~
> gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -DTERMCAP -DHAVE_UTHOST -DHAVE_TERMIOS_H -DHAVE_UNISTD_H -DSHELL=\"/bin/sh\" -DPTYCHAR=\"\" -DHEXDIGIT=\"\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o parserc.o parserc.c
> gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -DTERMCAP -DHAVE_UTHOST -DHAVE_TERMIOS_H -DHAVE_UNISTD_H -DSHELL=\"/bin/sh\" -DPTYCHAR=\"\" -DHEXDIGIT=\"\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o lock.o lock.c
> misc.c: In function ‘pty_open’:
> misc.c:91:17: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 91 | dup(slave_fd); dup(slave_fd); dup(slave_fd);
> | ^~~~~~~~~~~~~
> misc.c:91:32: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 91 | dup(slave_fd); dup(slave_fd); dup(slave_fd);
> | ^~~~~~~~~~~~~
> misc.c:91:47: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 91 | dup(slave_fd); dup(slave_fd); dup(slave_fd);
> | ^~~~~~~~~~~~~
> misc.c: In function ‘safe_popen’:
> splitvt.c: In function ‘main’:
> splitvt.c:450:57: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 450 | write(thisfd, selection, strlen(selection));
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> misc.c:934:43: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 934 | close(1); dup(pipe_fds[1]); close(0);
> | ^~~~~~~~~~~~~~~~
> misc.c:936:43: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 936 | close(0); dup(pipe_fds[0]); close(1);
> | ^~~~~~~~~~~~~~~~
> splitvt.c: In function ‘normal_input’:
> splitvt.c:546:17: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 546 | read(ttyfd, &c, 1);
> | ^~~~~~~~~~~~~~~~~~
> splitvt.c:591:35: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 591 | write(thisfd, selection, strlen(selection));
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> splitvt.c:625:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 625 | write(thisfd, &c, 1);
> | ^~~~~~~~~~~~~~~~~~~~
> terminal.c: In function ‘termcap_init’:
> terminal.c:112:55: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
> 112 | "Can't find termcap entry for terminal type \"%s\"", terminal_type);
> | ^~
> gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -DTERMCAP -DHAVE_UTHOST -DHAVE_TERMIOS_H -DHAVE_UNISTD_H -DSHELL=\"/bin/sh\" -DPTYCHAR=\"\" -DHEXDIGIT=\"\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o cut-paste.o cut-paste.c
> cut-paste.c: In function ‘put_sel_char’:
> cut-paste.c:48:20: error: implicit declaration of function ‘check_attr’ [-Werror=implicit-function-declaration]
> 48 | (*oldattr)=check_attr(c, *oldattr, on);
> | ^~~~~~~~~~
> In function ‘extract_sel’,
> inlined from ‘vt_getsel’ at cut-paste.c:286:11:
> cut-paste.c:95:12: warning: ‘mark1.x’ may be used uninitialized [-Wmaybe-uninitialized]
> 95 | if ( mark1->x == mark2->x )
> | ^
> cut-paste.c: In function ‘vt_getsel’:
> cut-paste.c:261:32: note: ‘mark1.x’ was declared here
> 261 | position here, cursor, mark1, mark2;
> | ^~~~~
> In function ‘extract_sel’,
> inlined from ‘vt_getsel’ at cut-paste.c:286:11:
> cut-paste.c:97:20: warning: ‘mark1.y’ may be used uninitialized [-Wmaybe-uninitialized]
> 97 | if ( mark1->y == mark2->y ) {
> | ^
> cut-paste.c: In function ‘vt_getsel’:
> cut-paste.c:261:32: note: ‘mark1.y’ was declared here
> 261 | position here, cursor, mark1, mark2;
> | ^~~~~
> cc1: some warnings being treated as errors
> make[1]: *** [<builtin>: cut-paste.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/splitvt_1.6.6-15_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
Reply to: