[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1011486: marked as done (tdfsb: reproducible-builds: embedded build paths in /usr/games/tdfsb)

Your message dated Tue, 09 Apr 2024 13:10:02 +0000
with message-id <E1ruBEg-00HSBK-Be@fasolo.debian.org>
and subject line Bug#1011486: fixed in tdfsb 0.0.10-4
has caused the Debian Bug report #1011486,
regarding tdfsb: reproducible-builds: embedded build paths in /usr/games/tdfsb
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1011486: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011486
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: tdfsb
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/games/tdfsb:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/tdfsb.html

  /build/1st/tdfsb-0.0.10/tdfsb.c:2909
  vs.
  /build/2/tdfsb-0.0.10/2nd/tdfsb.c:2909


The attached patch fixes this by adjusting compile.sh to include
-ffile-prefix-map in CFLAGS to avoid embedding the absolute path in
compiled files.

Alternately, updating to a newer version of debhelper-compat and dh, and
adjusting debian/patches/set_cflags.diff to only allow setting CFLAGS
would allow using the default CFLAGS from dpkg-buildflags.


With this patch applied, tdfsb should build reproducibly on
tests.reproducible-builds.org!


live well,
  vagrant

From cbb0273f0e3bc4264610158b4894d7418a6d1674 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 23 May 2022 20:46:06 +0000
Subject: [PATCH 1/4] compile.sh: Add -ffile-prefix-map to CFLAGS.

This avoids embedding the build path in the resulting binaries.

https://reproducible-builds.org/docs/build-path/
---
 compile.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compile.sh b/compile.sh
index f957eb2..740b227 100755
--- a/compile.sh
+++ b/compile.sh
@@ -11,7 +11,7 @@ execfind ()
     done;
 }
 
-CFLAGS="-O2 -Wall -g"
+CFLAGS="-O2 -Wall -g -ffile-prefix-map=$(pwd)=."
 SDL_CONFIG=$(execfind sdl-config sdl11-config sdl10-config sdl12-config \/boot\/develop\/tools/gnupro\/bin\/sdl-config);
 
 if ! "$SDL_CONFIG" --version > /dev/null; then
-- 
2.36.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: tdfsb
Source-Version: 0.0.10-4
Done: Andreas Beckmann <anbe@debian.org>

We believe that the bug you reported is fixed in the latest version of
tdfsb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011486@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <anbe@debian.org> (supplier of updated tdfsb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 09 Apr 2024 14:25:27 +0200
Source: tdfsb
Architecture: source
Version: 0.0.10-4
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Beckmann <anbe@debian.org>
Closes: 745645 1011486 1064997
Changes:
 tdfsb (0.0.10-4) unstable; urgency=medium
 .
   * QA upload.
   * Import package history into GIT.
   * Add a minimal Makefile instead of fixing up compile.sh. (Closes: #1064997)
   * Respect all flags from dpkg-buildflags.  (Closes: #1011486)
   * Fix building with -Werror=format-security.
   * Fix building with clang instead of gcc, thanks to Nicolas
     Sévelin-Radiguet.  (Closes: #745645)
   * Declare Rules-Requires-Root: no.
Checksums-Sha1:
 cdaf130d3163a8722afc7bd8be00c9a29b7182af 1923 tdfsb_0.0.10-4.dsc
 ad473a477e33cb93002f1a03515f8a99eb796c2d 5436 tdfsb_0.0.10-4.debian.tar.xz
 f873c99cafcb6fd3ee244d7d15876e3b2070d73b 11531 tdfsb_0.0.10-4_source.buildinfo
Checksums-Sha256:
 5b9b1faa72608e34757d5457dd994d280f15318fde24354f5578b8513e24ebd4 1923 tdfsb_0.0.10-4.dsc
 9c480ca93ce393ce4d69992849183394f82b483095a314f1f73145b2ec5dbfa5 5436 tdfsb_0.0.10-4.debian.tar.xz
 adbb2a491da051f7891367b0ca30458091e0aabc8c50be761175da6f705b8c14 11531 tdfsb_0.0.10-4_source.buildinfo
Files:
 91db8bdb7fd39df41e63ebec145fbdf1 1923 games optional tdfsb_0.0.10-4.dsc
 942468c89cec71c82e7ce80200df8f50 5436 games optional tdfsb_0.0.10-4.debian.tar.xz
 9157e8dbe4ec440168a1738b6f6c5eeb 11531 games optional tdfsb_0.0.10-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmYVNVIQHGFuYmVAZGVi
aWFuLm9yZwAKCRBfsz+TWentCDWIEACDOfOb0xUSulut/6I0SPgGBc4fRM0HRbVR
D9yflNY2aIu025Eh/IxBzctVDqvQLJOmYl8i0Exdxf6hShh6ekGr+rQ95AyUjoQu
VoUcvHybRKsiWuN64LQAS24BYHgTwR7CXmFvBlFXDXZG1RiHAkjFnVWN2fDaNJru
2zUSLmvpsYl50IoCE3+TjLuR0benF8KKY2Do60qBFU0lhWc3qs+dmtXxI7cQMpFM
iUWJPv5cXu82rRHL6NxsnTeeqskijx47y/vLfUBp3o99NaRjqbP4ITTlehKeAEiP
dS1W8FKB7Pu9QHctvTcZaa71dF5uJlkRwi02xPSWlA00pubKIyi53DbI70UQyHA/
KoLECwaBUr5FI2l1op/MclpGg01uH1YIS/mBU9/ebgumD8OchQxy1wb1aRgFLXSC
X3RUrb1N9M+xYMvaaWFIDPSIUuHX+nn7p718xug5DMnMFG5deQHre1K/J4uL5QYK
Eo0YSU814JFdRGayjxlqR/48Mkg5Xo7ri0A6lIsyo9OiaYk5F1Tq1YniBe8kv90g
3i31xjA6nc22JBkJtrRwnZzbSc7cJ1P5r8f5Nq0A/anD/Wr441vkooGArFH0tgVj
MLmToccFLvJgl8TtC/6pZgvW8KcQudLqzvrxqv1UmvXF0t1Q//oI/frGU8Psjt2Y
EB7DA0/IvQ==
=6NCX
-----END PGP SIGNATURE-----

Attachment: pgpLEGX_8g0hZ.pgp
Description: PGP signature


--- End Message ---
Reply to: