[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#779247: tracker.debian.org: obsolete build reproducibility action item not removed



Package: tracker.debian.org
Severity: normal
Tags: patch

Dear Maintainer,

since version 7:2.5.4-1 ffmpeg is listed as "reproducible" in
reproducible.json [1], but the package tracker [2] still claims:
"Fails to build during reproducibility testing"

The info popup shows, that the action item hasn't been updated since
ffmpeg builds reproducibly:
"Severity: normal
Created: 2015-01-29
Last Updated: 2015-02-21"

So it seems the tracker doesn't delete obsolete action items.

The following patch might fix this:
--- a/distro_tracker/vendor/debian/tracker_tasks.py
+++ b/distro_tracker/vendor/debian/tracker_tasks.py
@@ -2349,5 +2349,5 @@ class UpdateBuildReproducibilityTask(BaseTask):
                 extracted_info.append(reproducibility_info)

             ActionItem.objects.delete_obsolete_items([self.action_item_type],
-                                                     packages)
+                                                     [])
             PackageExtractedInfo.objects.bulk_create(extracted_info)

The rationale for this change is that the second argument of delete_obsolete_items is the list of non_obsolete_packages, whose items are not to be removed. But packages contains a list of all packages with a reproducibility status.

However, I haven't tested this patch.

Best regards,
Andreas


1: https://reproducible.debian.net/reproducible.json
2: https://tracker.debian.org/pkg/ffmpeg


Reply to: