Bug#1043043: UDD patches: marks Forwarded as invalid if not 'no', 'not-needed', 'yes' or URL

On Mon, 7 Aug 2023 01:19:38 +0200 Guillem Jover <guillem@debian.org> wrote:

> On Fri, 2023-08-04 at 23:35:27 -0300, David da Silva Polverari wrote:

> > When using https://udd.debian.org/patches.cgi, I notice that whenever
> > the Forwarded field contains anything other than "no", "not-needed",
> > "yes" or an URL, it gets marked as invalid.
>

Even 'Forwarded: yes' is regarded as invalid - see here:

https://udd.debian.org/patches.cgi?src="">

the patches marked "invalid" have been sent upstream by email but, sadly, there is no upstream bug tracker or url , so no url to include.

it looks like this comes from https://salsa.debian.org/qa/udd/-/blob/master/rimporters/patches.rb#206-222

line 222 requires that 'Forwarded: yes' be accompanied by a 'Bug' field (and on line 208 the bug must be http(s) url). This seems stricter than DEP3 ("Any value other than "no" or "not-needed" means that the patch has been forwarded upstream. Ideally the value is an URL proving that it has been forwarded and where one can find more information about its inclusion status.")

and then

https://salsa.debian.org/qa/udd/-/blob/master/web/patches.cgi i assume renders these as invalid.

the simplest fix looks.like having line 222 in patches.rb say

pa['forwarded_short'] = 'yes'

(and then modify

https://salsa.debian.org/qa/udd/-/blob/master/web/patches.cgi#194 to only have the <a> if e[:forwarded_url] is set)

Or patches.rb could allow mailto: in the same way as http(s)?

(either looks quite easy, and i could send a MR - but i dont know how to test it)