[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#836108: marked as done (libaccounts-qt: please use dbus-run-session to run tests)

Your message dated Fri, 15 Dec 2017 08:56:26 +0100
with message-id <8662186.nlFH7C7Z5O@pendragon>
and subject line Re: Bug#836108: libaccounts-qt: please use dbus-run-session to run tests
has caused the Debian Bug report #836108,
regarding libaccounts-qt: please use dbus-run-session to run tests
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
836108: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836108
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libaccounts-qt
Version: 1.13+20150813-1
Severity: normal
User: dbus@packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-x11 for tests, explicitly launching
dbus-launch. It also seems to be missing the necessary build-dependency
on dbus-x11 - presumably that gets pulled in by something else,
or the "cd -" masks the error.

It should be possible to replace dbus-x11 as follows:

* add a build-dependency on dbus (>= 1.8)
* replace "xvfb-run -a dbus-launch --exit-with-session make check" with
  "xvfb-run -a dbus-run-session -- make check"

If D-Bus is the only reason you are using xvfb, you can remove that too,
and just use "dbus-run-session -- make check".

While you're editing the override_dh_auto_test stanza, it's probably also
a good idea to use "&&" instead of ";" so that test failures aren't
ignored, and remove the "cd -" bashism. (Each line of a Makefile recipe
is run in its own shell invocation, so cd'ing to a directory does not
affect subsequent lines unless you use "\" for line joining.)

Thanks,
    S

--- End Message ---
--- Begin Message --- 
Source: libaccounts-qt
Source-Version: 1.15-1

In data martedì 30 agosto 2016 17:24:22 CET, Simon McVittie ha scritto:
> Source: libaccounts-qt
> Version: 1.13+20150813-1
> Severity: normal
> User: dbus@packages.debian.org
> Usertags: dbus-launch dbus-launch-for-tests
> 
> As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
> I'm trying to reduce how much dbus-launch is used in Debian.
> This package currently uses dbus-x11 for tests, explicitly launching
> dbus-launch. It also seems to be missing the necessary build-dependency
> on dbus-x11 - presumably that gets pulled in by something else,
> or the "cd -" masks the error.
> 
> It should be possible to replace dbus-x11 as follows:
> 
> * add a build-dependency on dbus (>= 1.8)
> * replace "xvfb-run -a dbus-launch --exit-with-session make check" with
>   "xvfb-run -a dbus-run-session -- make check"
> 
> If D-Bus is the only reason you are using xvfb, you can remove that too,
> and just use "dbus-run-session -- make check".

The tests were disabled / dropped in libaccounts-qt 1.15-1.

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
Reply to: