[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#915616: marked as done (libksysguard: 'testsuite' autopkgtest does not test the installed version)

Your message dated Sun, 12 Jan 2020 13:04:43 +0000
with message-id <E1iqcv5-00081p-FB@fasolo.debian.org>
and subject line Bug#915616: fixed in libksysguard 4:5.17.5-1
has caused the Debian Bug report #915616,
regarding libksysguard: 'testsuite' autopkgtest does not test the installed version
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
915616: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915616
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libksysguard
Version: 4:5.14.3-1
Severity: normal

The 'testsuite' autopkgtest for libksysguard is done with the build-needed
restriction, does not list any binary packages built by libksysguard as
test dependencies, and is basically a wrapper around dh_auto_test.

It appears this means it is testing a newly-compiled copy of libksysguard
built from the source code. This does not match the intention for
autopkgtests, which is that they test the binaries that are contained in
the .deb distributed by Debian:

    *However* note that the tests must test the *installed* version of the
    package, as opposed to programs or any other file from the built tree.
    — https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst

In particular this allows an autopkgtest for an executable to be used to
detect ABI breaks in one of its dependencies, which could not be detected
if the executable was rebuilt against the updated dependency.

Similar concepts include GNU's `make installcheck`[1] and GNOME's
installed-tests initiative[2].

If the upstream test suite is designed to be run in a built tree at
build-time and test the recently-built binaries, it is likely to need
code changes to become suitable for running against installed binaries.

For example, many of the dbus unit tests have been adapted (borrowing
the GNOME installed-tests conventions) so that they default to
reading data files from ${libexecdir}/installed-tests/dbus and
finding dbus-daemon in the PATH, which means they can be installed in
${libexecdir}/installed-tests/dbus themselves and run from there in order
to test the installed dbus binaries. When run as build-time tests, the
path to the data files and the path to the dbus-daemon (among others)
are overridden by environment variables that point into the build tree.

If KDE doesn't already have a system for doing this, there's nothing
particularly GNOME-specific about the GNOME installed-tests conventions,
so those would be as good a design as any other. The reference test
runner, gnome-desktop-testing, is written with GLib, but there would be
nothing to stop KDE from implementing a compatible runner in Qt/C++ if
that was considered to be a problem - the specification for the metadata
that describes tests is rather simple, and is based on a .desktop-style
file format.

    smcv

[1] https://www.gnu.org/prep/standards/html_node/Standard-Targets.html#Standard-Targets
    https://www.gnu.org/software/automake/manual/html_node/Install-Tests.html#Install-Tests
[2] https://wiki.gnome.org/Initiatives/GnomeGoals/InstalledTests

--- End Message ---
--- Begin Message --- 
Source: libksysguard
Source-Version: 4:5.17.5-1

We believe that the bug you reported is fixed in the latest version of
libksysguard, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 915616@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pino Toscano <pino@debian.org> (supplier of updated libksysguard package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 12 Jan 2020 13:38:57 +0100
Source: libksysguard
Architecture: source
Version: 4:5.17.5-1
Distribution: experimental
Urgency: medium
Maintainer: Debian/Kubuntu Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Pino Toscano <pino@debian.org>
Closes: 915613 915616 940741 940750
Changes:
 libksysguard (4:5.17.5-1) experimental; urgency=medium
 .
   * Team upload.
 .
   [ Maximiliano Curia ]
   * New upstream release (5.16.5).
   * Salsa CI automatic initialization by Tuco
   * Update build-deps and deps with the info from cmake
   * Drop the transitional package libkf5sysguard5 (Closes: 940750)
   * Drop the transitional package libkf5sysguard5-data (Closes: 940741)
 .
   [ Pino Toscano ]
   * New upstream release.
   * Update the build dependencies according to the upstream build system:
     - remove libqt5webkit5-dev
     - add libqt5webchannel5-dev, libxres-dev, and qtwebengine5-dev
     - explicitly add gettext
   * Bump the debhelper compatibility to 12:
     - switch the debhelper build dependency to debhelper-compat 12
     - remove debian/compat
   * Remove breaks/replaces for versions older than oldstable.
   * Drop the migration from libkf5sysguard-dbg, no more needed after two
     Debian stable releases.
   * Drop the 'testsuite' autopkgtest, as it does not test the installed
     packages. (Closes: #915613, #915616)
   * Update install files.
   * Unregister old conffiles.
   * Bump Standards-Version to 4.4.1, no changes required.
   * Update symbols files.
   * Do not use the ${shlibs:Depends} substvar in libkf5sysguard-data, as it
     does not exist.
   * Update lintian overrides.
   * Enable all the reprotest variations in the salsa CI.
Checksums-Sha1:
 da296c1f7a5a6695809831b6616872109b39e6c9 3395 libksysguard_5.17.5-1.dsc
 10eb95b7cb389809cc0cb1088a0b97a04eb694b1 605628 libksysguard_5.17.5.orig.tar.xz
 0d9ea11f1eb5068cb8efbfb71ce9e0cb3ac1225a 488 libksysguard_5.17.5.orig.tar.xz.asc
 2744a3901667c5be868616aaa25a70fa95467bbb 18252 libksysguard_5.17.5-1.debian.tar.xz
 646c98319f53f66a671e9cacbd6e73b02384c741 21601 libksysguard_5.17.5-1_source.buildinfo
Checksums-Sha256:
 d31b15649e2b29807f9109bf8abe8f0fdcd28c46572a5116306f24b0545e3cd2 3395 libksysguard_5.17.5-1.dsc
 f5d237af554d65740a28360e6d8fa39d4912239c5f21288846b1c934897a7e14 605628 libksysguard_5.17.5.orig.tar.xz
 dedb1861d1443920e255acfcc302d5b1c0ddd47655f91fbac4962dfbf340a170 488 libksysguard_5.17.5.orig.tar.xz.asc
 9b55a3eb42ea0bdbf224cc006ef61c6bc5359bfc82486c223c5c09841ffa3c4b 18252 libksysguard_5.17.5-1.debian.tar.xz
 6152012c22e074cb59c7620b64db86cedf19051d818f18cc81ac785fe6bb5aa2 21601 libksysguard_5.17.5-1_source.buildinfo
Files:
 18ff10b8ee6294440ee6ddd9c3cfd92b 3395 libs optional libksysguard_5.17.5-1.dsc
 27e1b1dad94f3115df2c28ba340232a1 605628 libs optional libksysguard_5.17.5.orig.tar.xz
 21fed4bfa58c2269dbcfc0f6e760a00f 488 libs optional libksysguard_5.17.5.orig.tar.xz.asc
 80dcc92ddff7aeb8ac65c77858034eb5 18252 libs optional libksysguard_5.17.5-1.debian.tar.xz
 58b1b61b73fb975a97f9501d7d5787f5 21601 libs optional libksysguard_5.17.5-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXyqfuC+mweEHcAcHLRkciEOxP00FAl4bE5oACgkQLRkciEOx
P00guQ//W7IqWbgRzRGkBQ9/rTBFrgUCnbZQnvsxiM7/7jMkxf8B+AR3+swcqfzM
1+FUqJ2A162b1/bDn4KTi+ynWkGA6wmfIb+o/hjpJg6p76PsrzbF60xJX+VSKbjA
sge5MwxWy/BTy8SJG4HJhVuRqgVLmkLirmvGdRC9nj/h8vKuqmUv0hHa6A9mRPp9
7Szy0wzQ0lWHbvjPN39pgWQWUqBdebJtzHgHF805Wpqna9vfB1rYtx7iqRzo3r+V
E85lxVpV9zHpoeKGyRs5nyMLKkUasswRF8BJq3qQo4/t6gCJqX0KQHppPUnVet5F
NVdbxcHVg111tUumMaArjfBjUIgpYBrh/m2T7vAKEqR3YZ8llKEYvHjZnUanR/WU
7KkQ3jDBHdHxasqdmMjP1JJuyuXi5LD6DRi0VZXR3yMDT0wv6TH7LbvFV00A/A5r
SV7BPxw/GZUsLSppOMzPvgvUZ3b8K+8m9H76Blc8zihPE2d49gBp71/WSY5+hKmp
xSGBE5hsYoUhKhj9Z4NyIo1FNAYyXejWhnq7ADlwJb9y8EHmKI0H1UZqCRtjWVQB
Ds0eK9/T+93cAjfFssVAGuX07fD5scoWPj3nD5+EuokfAAG509Oces260jpCWN2g
tCih1XHr4eio9PJHlibCWk9vZ5rAbIAia9UIP11uYe725LDTWX4=
=vYLF
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: