[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Please use consistent spelling of rmatrix version in seuratobject



Hi,

I intend to upgrade the Debian package of seuratobject to match the
latest upstream version of this package and seurat.  Unfortunately
I stumbled upon the fact that inside the DESCRIPTION file you specify

   Matrix (>= 1.3.3)

while the Matrix package is using the 1.3-x versioning scheme.  I'm
perfectly aware that the R world has the agreement that '.' and '-' sign
are sorting equally in version numbers.  But this is not true in other
versioning schemes.  So we get problems with the Debian packages where
1.3.3 is considered higher than 1.3-4  and the versioned dependencies
inside Debian will be broken.

You could support our work if you would follow the same spelling as
matrix is using in the version and simply apply the following patch:


diff --git a/DESCRIPTION b/DESCRIPTION
index eb5b94d..b91b07a 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -30,7 +30,7 @@ Encoding: UTF-8
 LazyData: true
 RoxygenNote: 7.1.1
 Depends: R (>= 4.0.0)
-Imports: grDevices, grid, Matrix (>= 1.3.3), methods, Rcpp (>= 1.0.5),
+Imports: grDevices, grid, Matrix (>= 1.3-3), methods, Rcpp (>= 1.0.5),
         rlang (>= 0.4.7), stats, tools, utils
 Suggests: testthat
 Collate: 'RcppExports.R' 'utils.R' 'zzz.R' 'generics.R' 'assay.R'


Thanks a lot for your support

     Andreas.

-- 
http://fam-tille.de


Reply to: