[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: CRAN package slider



Hi all,

I fixed the strict-prototypes warnings here https://github.com/DavisVaughan/slider/pull/175
(BTW, did you see Lionel's message about this on r-package-devel? https://stat.ethz.ch/pipermail/r-package-devel/2022q4/008589.html)

I have slider ready to go, but can't reproduce the issues seen on the CRAN machines and on the Debian autopkgtest. I've tried a number of things, including:

- Using the rocker/r-base image with released R 4.2.2 (2022-10-31), where I tried to run tests on the slider_0.2.2.tar.gz downloaded from CRAN with R CMD check and on the actual source code of slider pulled from GitHub with devtools::check()
- Submitting slider to win-devel, where it comes back clean
- Checking it locally on my own Mac, of course, with various versions of R including the exact r83217 revision it seems to be failing with on CRAN

Those tests should have errored earlier in `check_endpoints_cannot_be_na()` where a missing value check is run, but somehow it is bypassed and is then erroring on the next check, which checks that all values are in ascending order. So my guess is that it has something to do with lubridate and this month addition, which should always result in a missing value in the 4th element, but that must not be the case somehow (here are the expected results):

```
library(lubridate)
i <- as.Date("2019-01-30") + months(-3:0)
i + months(1)
#> [1] "2018-11-30" "2018-12-30" "2019-01-30" NA
```

If anyone can reproduce the test failures themselves, I'd be grateful if you could help me figure out what I might be missing here. I'm very motivated to try and get this fixed for CRAN.

-Davis

On Tue, Nov 8, 2022 at 6:30 AM Kurt Hornik <Kurt.Hornik@wu.ac.at> wrote:
Davis,

Please see

  <https://cran.r-project.org/web/checks/check_results_slider.html>

Unfortunately, in addition to the new strict-prototypes compilation
warnings in r-devel we also have test ERRORs for the Debian r-patched
and r-release checks, which also materialize in the autopkgtest checks
for the r-cran-slider package and thus currently prevent the migration
of the new R 4.2.2 Debian packages from unstable to testing, see

  <https://tracker.debian.org/pkg/r-base>

My hope is that this can be overridden quickly to get the Debian
packages migrated to testing, but in any case, can you please fix the
ERRORs (and ideally also the compilation warnings) as quickly as
possible?

Best
-k

Reply to: