Re: Bug#291194: Raising severity
clone 291194 -1
retitle -1 dpkg-deb: should force generating gnu tar archives
severity 291194 wishlist
tag 291194 - lenny-ignore
thanks
Hi!
On Sun, 2009-02-01 at 11:23:43 +0100, Raphael Hertzog wrote:
> On Sat, 31 Jan 2009, Adrian Bunk wrote:
> > I just ran into this bug when using a modified tar that defaults to
> > create posix archives:
>
> The simple work-around is to modify dpkg-deb to create tar archives
> used inside .deb with the option --format=gnu. Additionnaly, I think
> we should remove TAR_OPTIONS from the environment.
Heh, I've actually had this in mind for some time, and created a similar
patch yesterday, only using -H instead of --format. And, yes it should
unset TAR_OPTIONS, as the docs state that it gets appended to the
options given on the command line.
> Then the bug to support posix tar archive can again be wishlist.
Right, regardless of this getting fixed for lenny, it's the proper way
to deal with the bugs, so done so now.
> That could be even be done for lenny.
> Proposed patch is attached. I'd like to hear opinions from release
> managers and from Guillem. I tested the patch and it seems to work
> satisfactorily.
Even if the patch is is quite safe, I don't think this is really needed
for lenny, as tar defaults are not going to be changed there, and new
packages with a possible newer tar are only going to be produced in sid
(or an up to date testing).
But then it would be safer to have this already in place, and if the
release-team is ok with including this, then I think that's of course
fine.
> Note about the patch: it's on purpose that I didn't tag the error string for
> translation, the error will never happen.
unsetenv should only fail on NULL, "" or when the variable contains
'=', so better to just call it and ignore the return value. And just
stylistic, but maybe better to place the format argument in more or
less the same place in both calls. So once it's settled to which
branch to commit to, just go ahead.
regards,
guillem
Reply to: