Il 15/04/2011 20:06, Luca Falavigna ha scritto: > Il 14/04/2011 23:29, Philipp Kern ha scritto: >> After staring at the code a little longer: what keybinder returns from that >> function is a guint32, so shouldn't it be TYPE_UINT? And why does it >> overflow? I guess the reason it overflows comes from the X server (where >> it's a CARD32 so uint32, too). It's not entirely clear to me why, though. > > After talking with Ulrik (upstream developer), he made me notice current > upstream code has TYPE_UINT, so using it should be a better choice. He > told me this bug could be caused by X server being active for a lot of > time, making its timestamp bigger than the variable defined by Kupfer. Attaching debdiff this time. -- .''`. : :' : Luca Falavigna <dktrkranz@debian.org> `. `' `-
diff -Nru kupfer-0+v201/debian/changelog kupfer-0+v201/debian/changelog
--- kupfer-0+v201/debian/changelog 2010-07-17 14:29:47.000000000 +0200
+++ kupfer-0+v201/debian/changelog 2011-04-30 12:48:21.000000000 +0200
@@ -1,3 +1,11 @@
+kupfer (0+v201-2+squeeze1) stable; urgency=low
+
+ * debian/patches/TYPE_UINT.patch:
+ - Backport a fix from upstream git repository, use UINT signal
+ parameter type to fix an issue with ui.keybindings (Closes: #615060).
+
+ -- Luca Falavigna <dktrkranz@debian.org> Sat, 30 Apr 2011 12:52:09 +0200
+
kupfer (0+v201-2) unstable; urgency=low
* debian/control:
diff -Nru kupfer-0+v201/debian/patches/series kupfer-0+v201/debian/patches/series
--- kupfer-0+v201/debian/patches/series 2009-11-01 22:35:57.000000000 +0100
+++ kupfer-0+v201/debian/patches/series 2011-04-30 12:50:59.000000000 +0200
@@ -1 +1,2 @@
debian_path.patch
+TYPE_UINT.patch
diff -Nru kupfer-0+v201/debian/patches/TYPE_UINT.patch kupfer-0+v201/debian/patches/TYPE_UINT.patch
--- kupfer-0+v201/debian/patches/TYPE_UINT.patch 1970-01-01 01:00:00.000000000 +0100
+++ kupfer-0+v201/debian/patches/TYPE_UINT.patch 2011-04-30 12:47:59.000000000 +0200
@@ -0,0 +1,16 @@
+Description: Use UINT signal parameter type
+Origin: http://git.gnome.org/browse/kupfer/commit/?id=4b72c5317ba35462d8974efc5d35c0906febcdf7
+
+Index: kupfer-0+v201/kupfer/ui/keybindings.py
+===================================================================
+--- kupfer-0+v201.orig/kupfer/ui/keybindings.py 2011-04-14 22:24:52.954179649 +0200
++++ kupfer-0+v201/kupfer/ui/keybindings.py 2011-04-14 22:25:11.642179656 +0200
+@@ -34,7 +34,7 @@
+ self.emit("keybinding", target, time)
+
+ gobject.signal_new("keybinding", KeyboundObject, gobject.SIGNAL_RUN_LAST,
+- gobject.TYPE_BOOLEAN, (gobject.TYPE_INT, gobject.TYPE_INT))
++ gobject.TYPE_BOOLEAN, (gobject.TYPE_INT, gobject.TYPE_UINT))
+
+ _currently_bound = {}
+
Attachment:
signature.asc
Description: OpenPGP digital signature