[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#711223: pu: package dpkg-ruby/0.3.6+nmu2



Package: release.debian.org
Severity: normal
Tags: squeeze
User: release.debian.org@packages.debian.org
Usertags: pu

Hi,

I'd like to propose an update to dpkg-ruby in Squeeze because of a bug that
prevents upgrades to wheezy if apt-listbugs is installed: #585448.

Filehandles weren't closed so apt-listbugs crashes on particularly large
upgrades paths. The patch is from the maintainer who applied it in a
release which is in wheezy and above, but this is too late for someone
upgrading from squeeze hence this opu-update. I've confirmed that my
updated package solves the problem.

Such an update has been requested in the bug log since Jan 2012, with a
few pings after that, but no maintainer response yet, so I think the NMU
is justified.


Cheers,
Thijs
diff -Nru dpkg-ruby-0.3.6+nmu1/debian/changelog dpkg-ruby-0.3.6+nmu2/debian/changelog
--- dpkg-ruby-0.3.6+nmu1/debian/changelog	2010-08-26 17:44:03.000000000 +0200
+++ dpkg-ruby-0.3.6+nmu2/debian/changelog	2013-06-05 18:12:51.000000000 +0200
@@ -1,3 +1,11 @@
+dpkg-ruby (0.3.6+nmu2) squeeze; urgency=low
+
+  * Non-maintainer upload.
+  * Apply maintainer patch to close files once they're parsed,
+    preventing trouble on dist-upgrades to wheezy (Closes: #585448).
+
+ -- Thijs Kinkhorst <thijs@debian.org>  Wed, 05 Jun 2013 18:11:23 +0200
+
 dpkg-ruby (0.3.6+nmu1) unstable; urgency=high
 
   * Non-maintainer upload.
diff -Nru dpkg-ruby-0.3.6+nmu1/lib/debian.rb dpkg-ruby-0.3.6+nmu2/lib/debian.rb
--- dpkg-ruby-0.3.6+nmu1/lib/debian.rb	2010-08-26 17:25:15.000000000 +0200
+++ dpkg-ruby-0.3.6+nmu2/lib/debian.rb	2013-06-05 18:11:20.000000000 +0200
@@ -115,7 +115,10 @@
 
     def deb?(debfile)
       begin
-	Debian::Ar.new(debfile).open("debian-binary").read == DEBFORMAT_VERSION
+        f = Debian::Ar.new(debfile)
+        res = (f.open("debian-binary").read == DEBFORMAT_VERSION)
+        f.close
+        return res
       rescue NameError, Debian::ArError
 	false
       end
@@ -568,6 +571,7 @@
 	  @data.push(line.chomp)
 	}
       }
+      @artab.close
       freeze
     end
     def control= (c); @control = c; end

Reply to: