[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#782000: marked as done (unblock: upower/0.99.1-3.2)

Your message dated Mon, 06 Apr 2015 20:26:12 +0200
with message-id <5522CFC4.9000506@thykier.net>
and subject line Re: Bug#782000: unblock: upower/0.99.1-3.2
has caused the Debian Bug report #782000,
regarding unblock: upower/0.99.1-3.2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
782000: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782000
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package upower

+  [ Mike Gabriel ]
+  * Non-maintainer upload.

-> As Martin Pitt asked to help with fixing the below mentioned issue, I did
an NMU of upower just now. The upload has already been discussed with
and ack'ed by Niels Thykier on IRC today.

+  [ Vlad Orlov ]
+  * null-init-pointers.patch: new patch. Properly initialize two
+    pointers, avoid segfaults. (Closes: #774546).

-> This patch fixes crashes in mate-power-statistics and
gnome-power-statistics in certain situations (see #774546 for details
about when these crashes occur).

light+love,
Mike


unblock upower/0.99.1-3.2

-- System Information:
Debian Release: 8.0
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

diff -Nru upower-0.99.1/debian/changelog upower-0.99.1/debian/changelog
--- upower-0.99.1/debian/changelog	2014-11-28 16:42:02.000000000 +0100
+++ upower-0.99.1/debian/changelog	2015-04-06 12:21:31.000000000 +0200
@@ -1,3 +1,14 @@
+upower (0.99.1-3.2) unstable; urgency=medium
+
+  [ Mike Gabriel ]
+  * Non-maintainer upload.
+
+  [ Vlad Orlov ]
+  * null-init-pointers.patch: new patch. Properly initialize two
+    pointers, avoid segfaults. (Closes: #774546).
+
+ -- Mike Gabriel <sunweaver@debian.org>  Mon, 06 Apr 2015 12:03:26 +0200
+
 upower (0.99.1-3.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru upower-0.99.1/debian/patches/null-init-pointers.patch upower-0.99.1/debian/patches/null-init-pointers.patch
--- upower-0.99.1/debian/patches/null-init-pointers.patch	1970-01-01 01:00:00.000000000 +0100
+++ upower-0.99.1/debian/patches/null-init-pointers.patch	2015-04-06 12:02:17.000000000 +0200
@@ -0,0 +1,27 @@
+Description: NULL-initialize two pointers, avoid crash
+Author: Vlad Orlov <monsta@inbox.ru>
+Abstract:
+ Two uninitialized pointers in upower's code cause segfault
+ of gnome-power-statistics and mate-power-statistics in some
+ situations.
+
+--- a/libupower-glib/up-device.c
++++ b/libupower-glib/up-device.c
+@@ -422,7 +422,7 @@ GPtrArray *
+ up_device_get_history_sync (UpDevice *device, const gchar *type, guint timespec, guint resolution, GCancellable *cancellable, GError **error)
+ {
+ 	GError *error_local = NULL;
+-	GVariant *gva;
++	GVariant *gva = NULL;
+ 	guint i;
+ 	GPtrArray *array = NULL;
+ 	gboolean ret;
+@@ -502,7 +502,7 @@ GPtrArray *
+ up_device_get_statistics_sync (UpDevice *device, const gchar *type, GCancellable *cancellable, GError **error)
+ {
+ 	GError *error_local = NULL;
+-	GVariant *gva;
++	GVariant *gva = NULL;
+ 	guint i;
+ 	GPtrArray *array = NULL;
+ 	gboolean ret;
diff -Nru upower-0.99.1/debian/patches/series upower-0.99.1/debian/patches/series
--- upower-0.99.1/debian/patches/series	2014-11-28 16:24:28.000000000 +0100
+++ upower-0.99.1/debian/patches/series	2015-04-06 12:00:50.000000000 +0200
@@ -2,3 +2,4 @@
 git-tests-py3.4.patch
 git-split-tests.patch
 git-fix-memleak.patch
+null-init-pointers.patch

--- End Message ---
--- Begin Message --- 
On 2015-04-06 12:28, Mike Gabriel wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package upower
> 
> +  [ Mike Gabriel ]
> +  * Non-maintainer upload.
> 
> -> As Martin Pitt asked to help with fixing the below mentioned issue, I did
> an NMU of upower just now. The upload has already been discussed with
> and ack'ed by Niels Thykier on IRC today.
> 
> +  [ Vlad Orlov ]
> +  * null-init-pointers.patch: new patch. Properly initialize two
> +    pointers, avoid segfaults. (Closes: #774546).
> 
> -> This patch fixes crashes in mate-power-statistics and
> gnome-power-statistics in certain situations (see #774546 for details
> about when these crashes occur).
> 
> light+love,
> Mike
> 
> 
> unblock upower/0.99.1-3.2
> 
> [...]
> 

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: