Bug#835444: jessie-pu: package ovirt-guest-agent/1.0.10.2.dfsg-2+deb8u1
Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian.org@packages.debian.org
Usertags: pu
Hi Release Team,
There are two stupid bugs in ovirt-guest-agent which affects Jessie.
Both fixed in Sid + Stretch.
First is that its daemon is not started with the initscript[1]. Reason
is: it checks for executable bit on the daemon, but it's installed
without that. chmod a+x added to d/rules.
Second is that the logging is not working if daemon is started with
systemd as its log directory is not owned by the ovirtagent user[2].
To be extra safe, the chown was added to postinst.
Proposed patch is attached.
Thanks for considering,
Laszlo/GCS
[1] http://bugs.debian.org/782005
[2] http://bugs.debian.org/811481
diff -Nru ovirt-guest-agent-1.0.10.2.dfsg/debian/changelog ovirt-guest-agent-1.0.10.2.dfsg/debian/changelog
--- ovirt-guest-agent-1.0.10.2.dfsg/debian/changelog 2015-02-14 11:33:40.000000000 +0000
+++ ovirt-guest-agent-1.0.10.2.dfsg/debian/changelog 2016-08-20 10:34:30.000000000 +0000
@@ -1,3 +1,10 @@
+ovirt-guest-agent (1.0.10.2.dfsg-2+deb8u1) jessie; urgency=medium
+
+ * Install ovirt-guest-agent.py executable (closes: #782005).
+ * Change owner of log directory to ovirtagent in postinst (closes: #811481).
+
+ -- Laszlo Boszormenyi (GCS) <gcs@debian.org> Sat, 20 Aug 2016 10:34:30 +0000
+
ovirt-guest-agent (1.0.10.2.dfsg-2) unstable; urgency=low
* Rework useradd logic not to fail if gid 175 already present
diff -Nru ovirt-guest-agent-1.0.10.2.dfsg/debian/postinst ovirt-guest-agent-1.0.10.2.dfsg/debian/postinst
--- ovirt-guest-agent-1.0.10.2.dfsg/debian/postinst 2015-02-14 09:57:18.000000000 +0000
+++ ovirt-guest-agent-1.0.10.2.dfsg/debian/postinst 2016-08-20 10:34:30.000000000 +0000
@@ -12,4 +12,8 @@
udevadm settle
fi
+chown ovirtagent:ovirtagent /var/log/ovirt-guest-agent
+[ -f /var/log/ovirt-guest-agent/ovirt-guest-agent.log ] && \
+ chown ovirtagent:ovirtagent /var/log/ovirt-guest-agent/ovirt-guest-agent.log
+
#DEBHELPER#
diff -Nru ovirt-guest-agent-1.0.10.2.dfsg/debian/rules ovirt-guest-agent-1.0.10.2.dfsg/debian/rules
--- ovirt-guest-agent-1.0.10.2.dfsg/debian/rules 2014-08-10 17:37:53.000000000 +0000
+++ ovirt-guest-agent-1.0.10.2.dfsg/debian/rules 2016-08-20 10:34:30.000000000 +0000
@@ -8,13 +8,20 @@
export DH_OPTIONS
#DEB_DH_INSTALLINIT_ARGS := --upstart-only
+PKGDIR=$(CURDIR)/debian/ovirt-guest-agent
+
override_dh_auto_configure:
dh_auto_configure -- --without-sso
+override_dh_auto_install:
+ dh_auto_install
+ chmod a+x $(PKGDIR)/usr/share/ovirt-guest-agent/ovirt-guest-agent.py
+
override_dh_installudev:
dh_installudev --priority 55
%:
dh $@ --with autoreconf,python2
-.PHONY: override_dh_auto_configure override_dh_installudev
+.PHONY: override_dh_auto_configure override_dh_auto_install \
+ override_dh_installudev
Reply to: