Your message dated Sat, 16 Nov 2019 10:08:47 +0000 with message-id <83c9ffab6f08361485f70dda4733a7a24aeec09b.camel@adam-barratt.org.uk> and subject line Closing bugs for 10.2 point release fixes has caused the Debian Bug report #942827, regarding buster-pu: package ndppd/0.2.5-4+deb10u1 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 942827: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942827 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: buster-pu: package ndppd/0.2.5-4+deb10u1
- From: Jean-Michel Vourgère <nirgal@debian.org>
- Date: Tue, 22 Oct 2019 09:18:35 +0200
- Message-id: <2043308.oThlOV4Wx5@deimos>
Package: release.debian.org User: release.debian.org@packages.debian.org Usertags: pu Tags: buster Severity: normal Dear RT In buster, ndppd has a world writable pid file. This prevent the daemon to be stop/restarted, which is a real pain when you set it up. I would like to backport the fix from testing. Attached the proposal. Do you think this is ok? -- System Information: Debian Release: 10.1 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-6-amd64 (SMP w/8 CPU cores) Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enableddiff -Nru ndppd-0.2.5/debian/changelog ndppd-0.2.5/debian/changelog --- ndppd-0.2.5/debian/changelog 2018-11-16 17:26:06.000000000 +0100 +++ ndppd-0.2.5/debian/changelog 2019-10-17 10:21:15.000000000 +0200 @@ -1,3 +1,12 @@ +ndppd (0.2.5-4+deb10u1) buster; urgency=medium + + * Patch to avoid word writable pid file, that was breaking daemon init + scripts. (Closes: #942117) + * postinst script fixing pid file permissions for pre 0.2.5-4+deb10u1 + running daemons. + + -- Jean-Michel Vourgère <nirgal@debian.org> Thu, 17 Oct 2019 10:21:15 +0200 + ndppd (0.2.5-4) unstable; urgency=medium * Migrated vcs to salsa. diff -Nru ndppd-0.2.5/debian/patches/pid_perms ndppd-0.2.5/debian/patches/pid_perms --- ndppd-0.2.5/debian/patches/pid_perms 1970-01-01 01:00:00.000000000 +0100 +++ ndppd-0.2.5/debian/patches/pid_perms 2019-10-16 22:48:06.000000000 +0200 @@ -0,0 +1,28 @@ +Description: Umask pid file permissions + Pid file was created with default 666 permissions. This causes security + issues when trying to stop the process. init stopped working because + start-stop-daemon(8) refuses to handle these nasty permissions, since dpkg + version 1.19.3. +Author: Jean-Michel Vourgère <nirgal@debian.org> +Bug-Debian: https://bugs.debian.org/942117 +Bug: https://github.com/DanielAdolfsson/ndppd/issues/56 +Forwarded: yes +Last-Update: 2019-10-12 + +Index: ndppd-0.2.5/src/ndppd.cc +=================================================================== +--- ndppd-0.2.5.orig/src/ndppd.cc ++++ ndppd-0.2.5/src/ndppd.cc +@@ -274,10 +274,12 @@ int main(int argc, char* argv[], char* e + return -1; + + if (!pidfile.empty()) { ++ mode_t old_umask = umask(022); + std::ofstream pf; + pf.open(pidfile.c_str(), std::ios::out | std::ios::trunc); + pf << getpid() << std::endl; + pf.close(); ++ umask(old_umask); + } + + // Time stuff. diff -Nru ndppd-0.2.5/debian/patches/series ndppd-0.2.5/debian/patches/series --- ndppd-0.2.5/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ ndppd-0.2.5/debian/patches/series 2019-10-16 22:48:06.000000000 +0200 @@ -0,0 +1 @@ +pid_perms diff -Nru ndppd-0.2.5/debian/postinst ndppd-0.2.5/debian/postinst --- ndppd-0.2.5/debian/postinst 1970-01-01 01:00:00.000000000 +0100 +++ ndppd-0.2.5/debian/postinst 2019-10-17 10:19:32.000000000 +0200 @@ -0,0 +1,18 @@ +#!/bin/sh + +set -e + +case "$1" in + configure) + if [ -n "$2" ] && dpkg --compare-versions "$2" lt-nl 0.2.5-4+deb10u1 + then + # Buster version can't be stopped. See #942117 + if [ -f /var/run/ndppd.pid ] + then + chmod 644 /var/run/ndppd.pid + fi + fi + ;; +esac + +#DEBHELPER#Attachment: signature.asc
Description: This is a digitally signed message part.
--- End Message ---
--- Begin Message ---
- To: 931766-done@bugs.debian.org, 932900-done@bugs.debian.org, 935250-done@bugs.debian.org, 935252-done@bugs.debian.org, 935392-done@bugs.debian.org, 939015-done@bugs.debian.org, 939166-done@bugs.debian.org, 939313-done@bugs.debian.org, 939354-done@bugs.debian.org, 939432-done@bugs.debian.org, 939446-done@bugs.debian.org, 939526-done@bugs.debian.org, 939738-done@bugs.debian.org, 939757-done@bugs.debian.org, 939831-done@bugs.debian.org, 939890-done@bugs.debian.org, 939965-done@bugs.debian.org, 940112-done@bugs.debian.org, 940170-done@bugs.debian.org, 940245-done@bugs.debian.org, 940476-done@bugs.debian.org, 940521-done@bugs.debian.org, 940548-done@bugs.debian.org, 940685-done@bugs.debian.org, 940686-done@bugs.debian.org, 940818-done@bugs.debian.org, 940943-done@bugs.debian.org, 941168-done@bugs.debian.org, 941227-done@bugs.debian.org, 941348-done@bugs.debian.org, 941451-done@bugs.debian.org, 941468-done@bugs.debian.org, 941683-done@bugs.debian.org, 941738-done@bugs.debian.org, 942044-done@bugs.debian.org, 942075-done@bugs.debian.org, 942177-done@bugs.debian.org, 942209-done@bugs.debian.org, 942253-done@bugs.debian.org, 942349-done@bugs.debian.org, 942356-done@bugs.debian.org, 942446-done@bugs.debian.org, 942486-done@bugs.debian.org, 942524-done@bugs.debian.org, 942827-done@bugs.debian.org, 943339-done@bugs.debian.org, 943364-done@bugs.debian.org, 943594-done@bugs.debian.org, 943605-done@bugs.debian.org, 943667-done@bugs.debian.org, 943766-done@bugs.debian.org, 943846-done@bugs.debian.org, 943882-done@bugs.debian.org, 944002-done@bugs.debian.org, 944009-done@bugs.debian.org, 944064-done@bugs.debian.org, 944119-done@bugs.debian.org, 944133-done@bugs.debian.org, 944238-done@bugs.debian.org, 944252-done@bugs.debian.org, 944374-done@bugs.debian.org, 944390-done@bugs.debian.org
- Subject: Closing bugs for 10.2 point release fixes
- From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
- Date: Sat, 16 Nov 2019 10:08:47 +0000
- Message-id: <83c9ffab6f08361485f70dda4733a7a24aeec09b.camel@adam-barratt.org.uk>
Package: release.debian.org Version: 10.2 Hi, The fixes referenced by these bugs were included in today's 10.2 stable point release. Regards, Adam
--- End Message ---