[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#984494: marked as done (unblock: xpdf/3.04+git20210103-2)

Your message dated Thu, 4 Mar 2021 21:12:09 +0100
with message-id <e2aa9f0a-f670-9aef-8fb4-3b1c613566dd@debian.org>
and subject line Re: Bug#984494: unblock: xpdf/3.04+git20210103-2
has caused the Debian Bug report #984494,
regarding unblock: xpdf/3.04+git20210103-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
984494: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=984494
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package xpdf

-2 that I just uploaded contains a one-line patch correctly initializing the
psLevel variable. This fixes the PostScript generated for printing in
all cases where the user hasn't set a psLevel manually in the config
file. This was reported in #983880 and promptly fixed by Upstream.

I think printing PDFs is one of the most common things people do with
xpdf (apart from simply viewing them, of course), and since this is a
regression from the previous version, getting a fixed version into
bullseye is very important IMHO.

see source debdiff below.

unblock xpdf/3.04+git20210103-2


As an unrelated issue, I just noticed after uploading -2 that the
-D_FORTIFY_SOURCE=2 hardening buildflag fails to be correctly injected.
This can apparently be fixed by a small change to debian/rules:

     export DEB_BUILD_MAINT_OPTIONS=hardening=+all

    -export CPPFLAGS+=-DHAVE_PAPER_H
    +export DEB_CPPFLAGS_MAINT_APPEND = -DHAVE_PAPER_H

Does the release team consider this a permissible change for the hard
freeze, and should I upload a -3 straight away so that one unblock will
suffice for both fixes?

thanks,
Florian


diff -Nru xpdf-3.04+git20210103/debian/changelog xpdf-3.04+git20210103/debian/changelog
--- xpdf-3.04+git20210103/debian/changelog	2021-01-28 15:58:32.000000000 +0800
+++ xpdf-3.04+git20210103/debian/changelog	2021-03-04 14:20:04.000000000 +0800
@@ -1,3 +1,9 @@
+xpdf (3.04+git20210103-2) unstable; urgency=medium
+
+  * Fix printing when no psLevel is defined in xpdfrc (closes: #983880)
+
+ -- Florian Schlichting <fsfs@debian.org>  Thu, 04 Mar 2021 14:20:04 +0800
+
 xpdf (3.04+git20210103-1) unstable; urgency=medium
 
   * Import new upstream version 3.04+git20210103
diff -Nru xpdf-3.04+git20210103/debian/patches/983880.patch xpdf-3.04+git20210103/debian/patches/983880.patch
--- xpdf-3.04+git20210103/debian/patches/983880.patch	1970-01-01 08:00:00.000000000 +0800
+++ xpdf-3.04+git20210103/debian/patches/983880.patch	2021-03-04 14:17:41.000000000 +0800
@@ -0,0 +1,23 @@
+commit 1b27cc5bb4491aed9d65c9f98704a693e3aabe59
+Author: Adam Sampson <ats@offog.org>
+Date:   Wed Mar 3 14:14:52 2021 +0000
+
+    Initialise XPDFParams::psLevel.
+    
+    This meant that PostScript output didn't work unless you specified
+    psLevel explicitly in the config file.
+    
+    Reported by Frédéric Brière in Debian bug #983880.
+
+diff --git a/xpdf/XPDFParams.cc b/xpdf/XPDFParams.cc
+index 4929bed..f33dd1e 100644
+--- a/xpdf/XPDFParams.cc
++++ b/xpdf/XPDFParams.cc
+@@ -159,6 +159,7 @@ XPDFParams::XPDFParams(const char *cfgFileName) {
+   psImageableURY = psPaperHeight;
+   psCrop = true;
+   psDuplex = false;
++  psLevel = psLevel2;
+   initialZoom = "125";
+   continuousView = false;
+   createDefaultKeyBindings();
diff -Nru xpdf-3.04+git20210103/debian/patches/series xpdf-3.04+git20210103/debian/patches/series
--- xpdf-3.04+git20210103/debian/patches/series	2021-01-28 14:22:16.000000000 +0800
+++ xpdf-3.04+git20210103/debian/patches/series	2021-03-04 14:17:21.000000000 +0800
@@ -1 +1,2 @@
 wrapper-options-manpage.patch
+983880.patch

--- End Message ---
--- Begin Message --- 
Hi Florian,

On 04-03-2021 15:51, Florian Schlichting wrote:
> xpdf 3.04+git20210103-3 is on its way to the archive, the complete
> debdiff follows below.

unblocked, thanks.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: