[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1029632: marked as done (unblock: ruby3.1/3.1.2-5)

Your message dated Wed, 25 Jan 2023 19:53:28 +0100
with message-id <1d589181-d14e-1410-36bd-d39545aedeb4@debian.org>
and subject line Re: Bug#1029632: unblock: ruby3.1/3.1.2-5
has caused the Debian Bug report #1029632,
regarding unblock: ruby3.1/3.1.2-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1029632: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029632
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: ruby3.1@packages.debian.org
Control: affects -1 + src:ruby3.1

Please unblock package ruby3.1

This is a trivial bug fix, and even though there is no real block hint
in place, this bug report is to save you the time from wondering about
the changes.

[ Reason ]
3.1.2-4 had a regression. ./configure was being about an explicit
pkg-config binary, but pkg-config was not a build dependency. So
the pkg-config binary was not really there, so ./configure set the
corresponding configuration variable to an empty string making the
pkg-config bindings in mkmf.rb not really work.

[ Impact ]
This makes some packages fail to build from source, namely ruby-augeas
and ruby-libvirt.

[ Tests ]
An autopkgtest to catch similar issues in the future has been added, and
it passes while it failed with 3.1.2.4.

[ Risks ]
None.

[ Checklist ]
  [✓] all changes are documented in the d/changelog
  [✓] I reviewed all changes and I approve them
  [✓] attach debdiff against the package in testing

[ Other info ]
n/a

unblock ruby3.1/3.1.2-5

diff --git a/debian/changelog b/debian/changelog
index 59fe6c8a1..8e43cb693 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,17 @@
+ruby3.1 (3.1.2-5) unstable; urgency=medium
+
+  * Add autopkgtest to test pkg_config
+  * Add build dependency on pkg-config from pkgconf.
+    The absence of this build dependency made the check for whether
+    pkg-config works fail (because it was not there) at the ./configure
+    stage, making RbConfig::CONFIG["PKG_CONFIG"] empty, and therefore broke
+    the usage of pkg_config() in extconf.rb scripts.
+    This was noticed by Lucas Kanashiro (thanks!) in Ubuntu while rebuilding
+    all Ruby packages to add ruby3.1 support, where ruby-augeas and
+    ruby-libvirt failed to build.
+
+ -- Antonio Terceiro <terceiro@debian.org>  Wed, 25 Jan 2023 14:46:18 -0300
+
 ruby3.1 (3.1.2-4) unstable; urgency=medium
 
   * Replace cross pkg-config patch with patches applied upstream
diff --git a/debian/control b/debian/control
index 2d6602a40..9802975c0 100644
--- a/debian/control
+++ b/debian/control
@@ -19,6 +19,7 @@ Build-Depends: bison,
                libyaml-dev,
                netbase <!nocheck>,
                openssl <!nocheck>,
+               pkg-config (>= 1.8.0-7~),
                procps <!nocheck>,
                ruby3.1:native <cross>,
                rubygems-integration (>= 1.6) <!nocheck>,
diff --git a/debian/tests/control b/debian/tests/control
index 2b0bab840..bd3c7127a 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,3 +1,3 @@
-Tests: run-all bundled-gems builtin-extensions rubyconfig
-Depends: @
+Tests: run-all bundled-gems builtin-extensions rubyconfig pkg-config
+Depends: @, libffi-dev
 Restrictions: allow-stderr
diff --git a/debian/tests/pkg-config b/debian/tests/pkg-config
new file mode 100755
index 000000000..ce2bd6e23
--- /dev/null
+++ b/debian/tests/pkg-config
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+set -eu
+
+ruby="${1:-ruby3.1}"
+cd "${AUTOPKGTEST_TMP:-/tmp}"
+
+set -x
+$ruby -rmkmf -e 'pkg_config("libffi") or raise "pkg_config does not work"'

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Hi,

On 25-01-2023 18:54, Antonio Terceiro wrote:

Please unblock package ruby3.1


Discussed on IRC. ACK-ed.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: