--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: ddcutil: pre-approval request ddcutil-1.4.2-1 fixes bug #1031259
- From: Sanford Rockowitz <rockowitz@minsoft.com>
- Date: Fri, 10 Mar 2023 01:04:18 -0500
- Message-id: <167842825804.296694.9965790135766970552.reportbug@ritter0>
Package: ddcutil
Version: 1.4.2-1
Severity: normal
X-Debbugs-Cc: rockowitz@minsoft.com
Bug report #1031259 vs ddcutil 1.4.1-1 suggests installing files in
/usr/lib/modules-load.d to ensure that driver i2c-dev is loaded at system
startup, avoiding the possible need for user configuration after package
installation. The change was made in the upstream source, and ddcutil 1.4.2-1
was uploaded to mentors on 2023-02-22.
The package sponsor, Andrey Rakhmatullin, has suggested that a pre-approval
request be submitted at this point before uploading from mentors to sid.
The change consists of 2 new files installed into /usr/lib/modules-load.d, an
updated Changelog.md file, along with modified DEBIAN/changelog,
DEBIAN/ddcutil.install, DEBIAN/libddcutil4.install, and updates to relevant
Autotools files.
-- System Information:
Debian Release: bookworm/sid
APT prefers kinetic-updates
APT policy: (500, 'kinetic-updates'), (500, 'kinetic-security'), (500, 'kinetic')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.19.0-31-generic (SMP w/20 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages ddcutil depends on:
ii i2c-tools 4.3-2build1
ii libc6 2.36-0ubuntu4
ii libdrm2 2.4.113-2
ii libglib2.0-0 2.74.3-0ubuntu1
ii libkmod2 30+20220630-3ubuntu1
ii libudev1 251.4-1ubuntu7
ii libx11-6 2:1.8.1-2
ii libxrandr2 2:1.5.2-2
ii pci.ids 0.0~2022.08.07-1
ii usb.ids 2022.05.20-1
ii usbutils 1:014-1build1
ddcutil recommends no packages.
ddcutil suggests no packages.
diff -Nru ddcutil-1.4.1/CHANGELOG.md ddcutil-1.4.2/CHANGELOG.md
--- ddcutil-1.4.1/CHANGELOG.md 2023-01-23 10:47:29.000000000 -0500
+++ ddcutil-1.4.2/CHANGELOG.md 2023-02-21 13:26:28.000000000 -0500
@@ -1,5 +1,16 @@
# Changelog
+## [1.4.2] 2023-02-17
+
+### Added
+
+- **ddcutil** installation installs files /usr/lib/modules-load.d/ddcutil.conf
+ and /usr/lib/modules-load.d#libddcutil.conf to ensure that kernel module
+ i2c-dev is loaded at boot time if it is not built into the kernel. There are
+ two files so that when split up into distribution packages, each of the
+ command line **ddcutil** package and the shared library **libddcutil**
+ package installs a file.
+
## [1.4.1] 2023-01-16
### Fixed
diff -Nru ddcutil-1.4.1/configure ddcutil-1.4.2/configure
--- ddcutil-1.4.1/configure 2023-01-23 11:31:05.000000000 -0500
+++ ddcutil-1.4.2/configure 2023-02-21 13:27:43.000000000 -0500
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.71 for ddcutil 1.4.1.
+# Generated by GNU Autoconf 2.71 for ddcutil 1.4.2.
#
# Report bugs to <rockowitz@minsoft.com>.
#
@@ -621,8 +621,8 @@
# Identity of this package.
PACKAGE_NAME='ddcutil'
PACKAGE_TARNAME='ddcutil'
-PACKAGE_VERSION='1.4.1'
-PACKAGE_STRING='ddcutil 1.4.1'
+PACKAGE_VERSION='1.4.2'
+PACKAGE_STRING='ddcutil 1.4.2'
PACKAGE_BUGREPORT='rockowitz@minsoft.com'
PACKAGE_URL=''
@@ -1506,7 +1506,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures ddcutil 1.4.1 to adapt to many kinds of systems.
+\`configure' configures ddcutil 1.4.2 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1577,7 +1577,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of ddcutil 1.4.1:";;
+ short | recursive ) echo "Configuration of ddcutil 1.4.2:";;
esac
cat <<\_ACEOF
@@ -1753,7 +1753,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-ddcutil configure 1.4.1
+ddcutil configure 1.4.2
generated by GNU Autoconf 2.71
Copyright (C) 2021 Free Software Foundation, Inc.
@@ -2180,7 +2180,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by ddcutil $as_me 1.4.1, which was
+It was created by ddcutil $as_me 1.4.2, which was
generated by GNU Autoconf 2.71. Invocation command line was
$ $0$ac_configure_args_raw
@@ -2944,7 +2944,7 @@
printf "%s\n" "#define VERSION_VMINOR 4 " >>confdefs.h
-printf "%s\n" "#define VERSION_VMICRO 1 " >>confdefs.h
+printf "%s\n" "#define VERSION_VMICRO 2 " >>confdefs.h
printf "%s\n" "#define VERSION_VSUFFIX \"\" " >>confdefs.h
@@ -2954,7 +2954,7 @@
VERSION_VMINOR=4
-VERSION_VMICRO=1
+VERSION_VMICRO=2
VERSION_VSUFFIX=""
@@ -3506,7 +3506,7 @@
# Define the identity of the package.
PACKAGE='ddcutil'
- VERSION='1.4.1'
+ VERSION='1.4.2'
printf "%s\n" "#define PACKAGE \"$PACKAGE\"" >>confdefs.h
@@ -19678,7 +19678,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by ddcutil $as_me 1.4.1, which was
+This file was extended by ddcutil $as_me 1.4.2, which was
generated by GNU Autoconf 2.71. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -19746,7 +19746,7 @@
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config='$ac_cs_config_escaped'
ac_cs_version="\\
-ddcutil config.status 1.4.1
+ddcutil config.status 1.4.2
configured by $0, generated by GNU Autoconf 2.71,
with options \\"\$ac_cs_config\\"
diff -Nru ddcutil-1.4.1/configure.ac ddcutil-1.4.2/configure.ac
--- ddcutil-1.4.1/configure.ac 2023-01-23 11:03:08.000000000 -0500
+++ ddcutil-1.4.2/configure.ac 2023-02-21 13:26:28.000000000 -0500
@@ -16,7 +16,7 @@
m4_define([ddcutil_major_version], [1])
m4_define([ddcutil_minor_version], [4])
-m4_define([ddcutil_micro_version], [1])
+m4_define([ddcutil_micro_version], [2])
dnl ddcutil_version_suffix does not begin with hyphen, e.g. "dev", not "-dev"
m4_define([ddcutil_version_suffix], [""])
# m4_ifelse(ddcutil_version_suffix,[], m4_define([ddcutil_version], [a]),define([ddcutil_version],[b]))
diff -Nru ddcutil-1.4.1/data/Makefile.am ddcutil-1.4.2/data/Makefile.am
--- ddcutil-1.4.1/data/Makefile.am 2023-01-23 10:47:29.000000000 -0500
+++ ddcutil-1.4.2/data/Makefile.am 2023-02-21 13:26:28.000000000 -0500
@@ -11,8 +11,17 @@
rulesfiles = \
usr/lib/udev/rules.d/60-ddcutil.rules
+distributed_modulesfiles = \
+ usr/lib/modules-load.d/ddcutil.conf \
+ usr/lib/modules-load.d/libddcutil.conf
+
+installed_modulesfiles = usr/lib/modules-load.d/ddcutil.conf
+if ENABLE_SHARED_LIB_COND
+ installed_modulesfiles += usr/lib/modules-load.d/libddcutil.conf
+endif
+
# Causes files (with directory structure) to be included in tarball:
-EXTRA_DIST = $(resfiles) $(rulesfiles)
+EXTRA_DIST = $(resfiles) $(rulesfiles) $(distributed_modulesfiles)
# Target directory (/usr/local/share/ddcutil/data or /usr/share/ddcutil/data):
ddcutildir = $(datadir)/ddcutil/data
@@ -24,9 +33,13 @@
rulesdir = ${prefix}/lib/udev/rules.d
rules_DATA = $(rulesfiles)
+# Similar comment for modules-load.d
+installed_modulesdir = $(prefix)/lib/modules-load.d
+installed_modules_DATA = $(installed_modulesfiles)
+
+# include FindDDCUtil.cmake in tarball:
+EXTRA_DIST += cmake/ddcutil/FindDDCUtil.cmake
if ENABLE_SHARED_LIB_COND
- # include FindDDCUtil.cmake in tarball:
- EXTRA_DIST += cmake/ddcutil/FindDDCUtil.cmake
# where make install finds FindDDCUtil.cmake:
cmake_DATA = cmake/ddcutil/FindDDCUtil.cmake
# where FindDDCUtil.cmake will installed:
diff -Nru ddcutil-1.4.1/data/Makefile.in ddcutil-1.4.2/data/Makefile.in
--- ddcutil-1.4.1/data/Makefile.in 2023-01-23 11:31:04.000000000 -0500
+++ ddcutil-1.4.2/data/Makefile.in 2023-02-21 13:27:43.000000000 -0500
@@ -93,7 +93,7 @@
POST_UNINSTALL = :
build_triplet = @build@
host_triplet = @host@
-@ENABLE_SHARED_LIB_COND_TRUE@am__append_1 = cmake/ddcutil/FindDDCUtil.cmake
+@ENABLE_SHARED_LIB_COND_TRUE@am__append_1 = usr/lib/modules-load.d/libddcutil.conf
subdir = data
ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
am__aclocal_m4_deps = $(top_srcdir)/m4/ax_prog_doxygen.m4 \
@@ -155,8 +155,9 @@
$(am__cd) "$$dir" && rm -f $$files; }; \
}
am__installdirs = "$(DESTDIR)$(cmakedir)" "$(DESTDIR)$(ddcutildir)" \
- "$(DESTDIR)$(rulesdir)"
-DATA = $(cmake_DATA) $(ddcutil_DATA) $(rules_DATA)
+ "$(DESTDIR)$(installed_modulesdir)" "$(DESTDIR)$(rulesdir)"
+DATA = $(cmake_DATA) $(ddcutil_DATA) $(installed_modules_DATA) \
+ $(rules_DATA)
am__tagged_files = $(HEADERS) $(SOURCES) $(TAGS_FILES) $(LISP)
am__DIST_COMMON = $(srcdir)/Makefile.in
DISTFILES = $(DIST_COMMON) $(DIST_SOURCES) $(TEXINFOS) $(EXTRA_DIST)
@@ -347,9 +348,18 @@
rulesfiles = \
usr/lib/udev/rules.d/60-ddcutil.rules
+distributed_modulesfiles = \
+ usr/lib/modules-load.d/ddcutil.conf \
+ usr/lib/modules-load.d/libddcutil.conf
+
+installed_modulesfiles = usr/lib/modules-load.d/ddcutil.conf \
+ $(am__append_1)
# Causes files (with directory structure) to be included in tarball:
-EXTRA_DIST = $(resfiles) $(rulesfiles) $(am__append_1)
+
+# include FindDDCUtil.cmake in tarball:
+EXTRA_DIST = $(resfiles) $(rulesfiles) $(distributed_modulesfiles) \
+ cmake/ddcutil/FindDDCUtil.cmake
# Target directory (/usr/local/share/ddcutil/data or /usr/share/ddcutil/data):
ddcutildir = $(datadir)/ddcutil/data
@@ -360,6 +370,10 @@
# udev/rules.d is always a subdirectory of /usr/lib
rulesdir = ${prefix}/lib/udev/rules.d
rules_DATA = $(rulesfiles)
+
+# Similar comment for modules-load.d
+installed_modulesdir = $(prefix)/lib/modules-load.d
+installed_modules_DATA = $(installed_modulesfiles)
@ENABLE_SHARED_LIB_COND_TRUE@cmake_DATA = cmake/ddcutil/FindDDCUtil.cmake
@ENABLE_SHARED_LIB_COND_TRUE@cmakedir = $(libdir)/cmake/ddcutil
all: all-am
@@ -442,6 +456,27 @@
@list='$(ddcutil_DATA)'; test -n "$(ddcutildir)" || list=; \
files=`for p in $$list; do echo $$p; done | sed -e 's|^.*/||'`; \
dir='$(DESTDIR)$(ddcutildir)'; $(am__uninstall_files_from_dir)
+install-installed_modulesDATA: $(installed_modules_DATA)
+ @$(NORMAL_INSTALL)
+ @list='$(installed_modules_DATA)'; test -n "$(installed_modulesdir)" || list=; \
+ if test -n "$$list"; then \
+ echo " $(MKDIR_P) '$(DESTDIR)$(installed_modulesdir)'"; \
+ $(MKDIR_P) "$(DESTDIR)$(installed_modulesdir)" || exit 1; \
+ fi; \
+ for p in $$list; do \
+ if test -f "$$p"; then d=; else d="$(srcdir)/"; fi; \
+ echo "$$d$$p"; \
+ done | $(am__base_list) | \
+ while read files; do \
+ echo " $(INSTALL_DATA) $$files '$(DESTDIR)$(installed_modulesdir)'"; \
+ $(INSTALL_DATA) $$files "$(DESTDIR)$(installed_modulesdir)" || exit $$?; \
+ done
+
+uninstall-installed_modulesDATA:
+ @$(NORMAL_UNINSTALL)
+ @list='$(installed_modules_DATA)'; test -n "$(installed_modulesdir)" || list=; \
+ files=`for p in $$list; do echo $$p; done | sed -e 's|^.*/||'`; \
+ dir='$(DESTDIR)$(installed_modulesdir)'; $(am__uninstall_files_from_dir)
install-rulesDATA: $(rules_DATA)
@$(NORMAL_INSTALL)
@list='$(rules_DATA)'; test -n "$(rulesdir)" || list=; \
@@ -506,7 +541,7 @@
check: check-am
all-am: Makefile $(DATA) all-local
installdirs:
- for dir in "$(DESTDIR)$(cmakedir)" "$(DESTDIR)$(ddcutildir)" "$(DESTDIR)$(rulesdir)"; do \
+ for dir in "$(DESTDIR)$(cmakedir)" "$(DESTDIR)$(ddcutildir)" "$(DESTDIR)$(installed_modulesdir)" "$(DESTDIR)$(rulesdir)"; do \
test -z "$$dir" || $(MKDIR_P) "$$dir"; \
done
install: install-am
@@ -560,7 +595,8 @@
info-am:
install-data-am: install-cmakeDATA install-data-local \
- install-ddcutilDATA install-rulesDATA
+ install-ddcutilDATA install-installed_modulesDATA \
+ install-rulesDATA
@$(NORMAL_INSTALL)
$(MAKE) $(AM_MAKEFLAGS) install-data-hook
install-dvi: install-dvi-am
@@ -606,7 +642,7 @@
ps-am:
uninstall-am: uninstall-cmakeDATA uninstall-ddcutilDATA \
- uninstall-rulesDATA
+ uninstall-installed_modulesDATA uninstall-rulesDATA
.MAKE: install-am install-data-am install-strip
@@ -617,18 +653,18 @@
install-data install-data-am install-data-hook \
install-data-local install-ddcutilDATA install-dvi \
install-dvi-am install-exec install-exec-am install-html \
- install-html-am install-info install-info-am install-man \
- install-pdf install-pdf-am install-ps install-ps-am \
- install-rulesDATA install-strip installcheck installcheck-am \
- installdirs maintainer-clean maintainer-clean-generic \
- mostlyclean mostlyclean-generic mostlyclean-libtool pdf pdf-am \
- ps ps-am tags-am uninstall uninstall-am uninstall-cmakeDATA \
- uninstall-ddcutilDATA uninstall-rulesDATA
+ install-html-am install-info install-info-am \
+ install-installed_modulesDATA install-man install-pdf \
+ install-pdf-am install-ps install-ps-am install-rulesDATA \
+ install-strip installcheck installcheck-am installdirs \
+ maintainer-clean maintainer-clean-generic mostlyclean \
+ mostlyclean-generic mostlyclean-libtool pdf pdf-am ps ps-am \
+ tags-am uninstall uninstall-am uninstall-cmakeDATA \
+ uninstall-ddcutilDATA uninstall-installed_modulesDATA \
+ uninstall-rulesDATA
.PRECIOUS: Makefile
-
-@ENABLE_SHARED_LIB_COND_TRUE@ # include FindDDCUtil.cmake in tarball:
@ENABLE_SHARED_LIB_COND_TRUE@ # where make install finds FindDDCUtil.cmake:
@ENABLE_SHARED_LIB_COND_TRUE@ # where FindDDCUtil.cmake will installed:
diff -Nru ddcutil-1.4.1/data/usr/lib/modules-load.d/ddcutil.conf ddcutil-1.4.2/data/usr/lib/modules-load.d/ddcutil.conf
--- ddcutil-1.4.1/data/usr/lib/modules-load.d/ddcutil.conf 1969-12-31 19:00:00.000000000 -0500
+++ ddcutil-1.4.2/data/usr/lib/modules-load.d/ddcutil.conf 2023-02-21 13:25:49.000000000 -0500
@@ -0,0 +1 @@
+i2c-dev
diff -Nru ddcutil-1.4.1/data/usr/lib/modules-load.d/libddcutil.conf ddcutil-1.4.2/data/usr/lib/modules-load.d/libddcutil.conf
--- ddcutil-1.4.1/data/usr/lib/modules-load.d/libddcutil.conf 1969-12-31 19:00:00.000000000 -0500
+++ ddcutil-1.4.2/data/usr/lib/modules-load.d/libddcutil.conf 2023-02-21 13:25:49.000000000 -0500
@@ -0,0 +1 @@
+i2c-dev
diff -Nru ddcutil-1.4.1/debian/changelog ddcutil-1.4.2/debian/changelog
--- ddcutil-1.4.1/debian/changelog 2023-01-26 04:00:00.000000000 -0500
+++ ddcutil-1.4.2/debian/changelog 2023-02-18 04:00:00.000000000 -0500
@@ -1,3 +1,15 @@
+ddcutil (1.4.2-1) unstable; urgency=medium
+
+ * New upstream release (Closes: #1031259)
+
+ * debian/ddcutil.install
+ - install /usr/lib/modules-load.d/ddcutil.conf
+
+ * debian/libddcutil4.install
+ - install /usr/lib/modules-load.d/libddcutil.conf
+
+ -- Sanford Rockowitz <rockowitz@minsoft.com> Sat, 18 Feb 2023 05:00:00 -0400
+
ddcutil (1.4.1-1) unstable; urgency=medium
* New upstream release
diff -Nru ddcutil-1.4.1/debian/ddcutil.install ddcutil-1.4.2/debian/ddcutil.install
--- ddcutil-1.4.1/debian/ddcutil.install 2023-01-25 13:21:18.000000000 -0500
+++ ddcutil-1.4.2/debian/ddcutil.install 2023-02-16 18:49:46.000000000 -0500
@@ -2,3 +2,4 @@
/usr/share/man
/usr/share/ddcutil/data
/usr/lib/udev/rules.d
+/usr/lib/modules-load.d/ddcutil.conf
diff -Nru ddcutil-1.4.1/debian/libddcutil4.install ddcutil-1.4.2/debian/libddcutil4.install
--- ddcutil-1.4.1/debian/libddcutil4.install 2021-01-29 22:31:56.000000000 -0500
+++ ddcutil-1.4.2/debian/libddcutil4.install 2023-02-16 18:50:41.000000000 -0500
@@ -1 +1,2 @@
usr/lib*/*/libddcutil.so.4*
+usr/lib/modules-load.d/libddcutil.conf
--- End Message ---
--- Begin Message ---
- To: Sanford Rockowitz <rockowitz@minsoft.com>, 1032614-done@bugs.debian.org
- Subject: Re: Bug#1032614: ddcutil: pre-approval request ddcutil-1.4.2-1 fixes bug #1031259
- From: Sebastian Ramacher <sramacher@debian.org>
- Date: Mon, 3 Apr 2023 20:33:12 +0200
- Message-id: <ZCsb6J8H1GSfozC/@ramacher.at>
- In-reply-to: <639124bf-a9dc-f239-1f13-9ae26ab7d10e@minsoft.com>
- References: <167842825804.296694.9965790135766970552.reportbug@ritter0> <ec00a138-447b-312c-b1b6-4d2b73fe1694@minsoft.com> <ZA7t1bmi1dTHq83h@ramacher.at> <53256dea-7c33-a801-2cdc-c3fac832d983@minsoft.com> <ZA8MCFYnUgGAEfwY@ramacher.at> <6c6abf3a-e38c-537b-7d6c-6f76f08566a2@minsoft.com> <167842825804.296694.9965790135766970552.reportbug@ritter0> <ZA9ktmg76OiPmCy2@ramacher.at> <[🔎] ZCiGfU8Bo5+cncbN@ramacher.at> <639124bf-a9dc-f239-1f13-9ae26ab7d10e@minsoft.com>
On 2023-04-03 12:24:43 -0400, Sanford Rockowitz wrote:
> On 4/1/23 15:31, Sebastian Ramacher wrote:
> > On 2023-03-13 19:00:22 +0100, Sebastian Ramacher wrote:
> > > On 2023-03-13 13:28:47 -0400, Sanford Rockowitz wrote:
> > > > On 3/13/23 07:42, Sebastian Ramacher wrote:
> > > > > On 2023-03-13 07:25:41 -0400, Sanford Rockowitz wrote:
> > > > > > On 3/13/23 05:33, Sebastian Ramacher wrote:
> > > > > > > On 2023-03-11 07:51:16 -0500, Sanford Rockowitz wrote:
> > > > > > > > [Reason ]
> > > > > > > > (Explain what the reason for the unblock request is.)
> > > > > > > > As noted, the unblock request addresses bug #1031259. ddcutil requires
> > > > > > > > driver i2c-dev. If it happens not to be built into the kernel, this entails
> > > > > > > > post-installation system configuration. Despite extensive documentation and
> > > > > > > > application warnings if the driver is not loaded, this can be challenging
> > > > > > > > for inexperienced users.
> > > > > > > >
> > > > > > > > > [ Impact ]
> > > > > > > > > (What is the impact for the user if the unblock isn't granted?)
> > > > > > > > Manual post installation configuration will continue to be required as
> > > > > > > > previously.
> > > > > > > > > [ Tests ]
> > > > > > > > > (What automated or manual tests cover the affected code?)
> > > > > > > > None
> > > > > > > > > [ Risks ]
> > > > > > > > > (Discussion of the risks involved. E.g. code is trivial or
> > > > > > > > > complex, key package vs leaf package, alternatives available.)
> > > > > > > > The changes are trivial, ensuring that driver i2c-dev is loaded if it is not
> > > > > > > > already built into the kernel. Package libddccontrol0, an alternative to
> > > > > > > > ddcutil for monitor control, installs file ddccontrol-i2c-dev.conf, which
> > > > > > > > loads i2c-dev. The contents of that file, a single line containing
> > > > > > > > "i2c-dev", is identical to the contents of the files to be installed by
> > > > > > > > ddcutil. Additional examples of packages that install files in
> > > > > > > > /user/lib/modules-load.d are fwupd, which installs file fwupd-msc.conf, and
> > > > > > > > encryptfs-utils, which installs file ecryptfs.conf.
> > > > > > > The prpoposed changes also introduce a policy violation:
> > > > > > > /usr/lib/modules-load.d/libddcutil.conf installed in libddcutil4 is not
> > > > > > > versioned the same way as the shared library. See section 8.2 for more
> > > > > > > details.
> > > > > > >
> > > > > > > Cheers
> > > > > > >
> > > > > > > > If the installed conf file were incorrect, the only effect would be an error
> > > > > > > > in the system log, and manual user configuration would still be required as
> > > > > > > > before.
> > > > > > > >
> > > > > > > > The only (potential) known dependency within Debian is from KDE
> > > > > > > > PowerDevil. However, PowerDevil, as installed by Debian, is built with use
> > > > > > > > of libddcutil if-tested out. (Recommended since its use of libddcutil is
> > > > > > > > "proof of concept" level code.)
> > > > > > > >
> > > > > > > > > [ Checklist ]
> > > > > > > > > [x] all changes are documented in the d/changelog
> > > > > > > > > [x ] I reviewed all changes and I approve them
> > > > > > > > > [x ] attach debdiff against the package in testing
> > > > > > > > >
> > > > > > > > > [ Other info ]
> > > > > > > > > (Anything else the release team should know.)
> > > > > > As I read section 8.2, there are two possibilities. The first is to version
> > > > > > the name of the file installed in /usr/lib/modules-load.d, e.g.
> > > > > > libddcutil4.conf for package libddcutil4. The second is to create an
> > > > > > additional package, named e.g. libddcutil-aux, that installs libddcutil.conf
> > > > > > and on which package libddcutil4 and successor packages libddcutilN depend.
> > > > > > The former has the advantage that it doesn't introduce an additional package
> > > > > > simply to install a single file, and the disadvantage that it relies on a
> > > > > > naming convention for the installed libddcutilN.conf file, which could
> > > > > > easily be overlooked when bumping the SONAME.
> > > > > As we're in hard freeze, option 2 is not an option for bookworm.
> > > > >
> > > > > > A third alternative is to not install a modules-load.d conf file for
> > > > > > libddcutil, and instead rely on packages using the shared library to install
> > > > > > a conf file. But that would multiply the number of packages installing
> > > > > > files in modules-load.d, and the potential for errors.
> > > > > That doesn't really sound like a solution to the bug. It would leak
> > > > > implementation details of libddcutil to all the reverse dependencies.
> > > > >
> > > > > Cheers
> > > > Setting aside what's possible given the bookworm freeze, do you have a
> > > > strong opinion as to whether the naming convention or separate package is
> > > > preferable/acceptable? I don't feel strongly that the update has to go into
> > > > bookworm. I wanted to address the "bug report" promptly, but the change is
> > > > more of an enhancement. Nothing is really actually broken, it's just that a
> > > > post installation step is necessary for some users, which it would be kind
> > > > to avoid.
> > > An additional binary package for a file with one line is overkill, IMHO.
> > Any news here or can we close the bug?
> >
> > Cheers
> Let's close the pre-approval request bug 1032614. The underlying bug,
> 1031259, is a (very reasonable) enhancement request, not an actual bug. I
> would have liked to clear it off the table, but at this point I don't think
> it warrants a freeze exception. I'm going to have think through how adding
> a versioned modules-load.d file for libddcutil would work in non-Debian
> based distributions.
Okay, closing.
Cheers
--
Sebastian Ramacher
--- End Message ---