[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1033811: unblock: mariadb/1:10.11.2-2



Control: tags -1 moreinfo

Hi Otto,

On 02-04-2023 05:50, Otto Kekäläinen wrote:
This Debian revision has been carefully crafted to only include bug
fixes, test improvements and translations (following the release
policy[2]). There are no risky functional changes, and the package has
not had any new bugs reported for several weeks and confidence that
this is the best version for Bookworm is high.

I hope you realize that you're stretching it:
 68 files changed, 11039 insertions(+), 404 deletions(-)

Several of these changes are not really appropriate and should have been done before the hard freeze. The idea of the freeze schedule is to stabilize the archive, particularly key packages. mariadb is a key package.

One of the changes I'm not please with is that you are renaming variables. Really, now?

Why now change from /usr/bin/mysql to /usr/bin/mariadb when the former is a symlink to the latter. Seems like unnecessary risks. (You even seem to have missed usr/bin/mysqladmin in mariadb-server.postrm, or is it in postrm better to have the link?)

Renaming patches (why and why now?) also doesn't help with a review; it's difficult to see if they are the same.

You drop the Hurd patch, but I couldn't find it documented. (Hurd has been failing since the first unversioned mariadb, so I can guess, but the point of unblock requests is that I shouldn't need to).

During my review several days ago I got to the 2464-log-missing-upgrade.patch. I might continue the review later but for now I'm out of spoons.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: