After the installation of ibus-keyman the ibus daemon needs to be restarted which is what the `postinst` script tries to do. It restarts or stops ibus-daemon, then checks if ibus-daemon is running - if not it will start it. If any of these steps fail we still want to successfully finish the installation. Since then ibus is not running the user will not be able to see any installed Keyman keyboards and will have to logout or reboot which will start ibus.-set -e +# Don't call `set -e`. Even if some commands should fail, it's still +# worth running the rest of the commands. Can you elaborate?
If we return with a non-exit code from the postinst script instead the installation of ibus-keyman aborts. The user can then try to install again which might lead into the same error, leaving him with an uninstallable ibus-keyman where the only thing that failed was the failure to (re-)start ibus.
Since all of postinst deals with ibus-daemon which is not part of the ibus-keyman package it seems to me that ignoring failures would be acceptable. This means the admin (who in most cases will be an ordinary user) won't be aware of problems with the postinst script, but he might notice ibus-daemon not running. Ignoring these postinst errors makes it harder for the developer to notice and fix errors in the postinst script, but IMO gives a better experience for the ordinary user.
That might well be the only change. New upstream versions get released simultaneously with the same version on all platforms, so it can happen that there is a new version without any changes on a platform. IMO this still has value since it simplifies dealing with help requests (the latest version of the binary is the latest version in the source code).Did I miss something but is the *only* change upstream the addition echo?
Doesn't feel very appropriate at this stage...That's your call. I still would like to see this version be available in Bookworm, but if you decide that's not an appropriate change I can live with that.
Thanks, Eberhard
Attachment:
OpenPGP_0xE9140597606020D3.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature