[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1041854: marked as done (bookworm-pu: package calibre/6.13.0+repack-2+deb12u1)

Your message dated Sat, 07 Oct 2023 09:59:38 +0000
with message-id <E1qp45y-00A4B5-VS@coccia.debian.org>
and subject line Released with 12.2
has caused the Debian Bug report #1041854,
regarding bookworm-pu: package calibre/6.13.0+repack-2+deb12u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1041854: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1041854
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: calibre@packages.debian.org, yokota.hgml@gmail.com
Control: affects -1 + src:calibre

[ Reason ]
To fix Debian bug 1041779
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1041779

[ Impact ]
Preferences dialog won't work

[ Tests ]
Manually reproduces this bug, and confirm to fixed the bug with this patch.

[ Risks ]
The fix is trivial.
This bug is already fixed in calibre/6.15.1-4 (Debian bug 1034089).

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
Fixes Python syntax mismatch.

[ Other info ]
The patch is taken from Debian unstable code.
  https://github.com/debian-
calibre/calibre/blob/debian/6.15.1-4/debian/patches/0027-TypeError-on-opening-
Preferences-Closes-1034089.patch

See also Debian bug 1034089.
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034089

Attached debdiff can be examine from online.
  https://github.com/debian-
calibre/calibre/compare/debian/6.13.0+repack-2...debian/6.13.0+repack-2+deb12u1

diff --git a/debian/changelog b/debian/changelog
index e484562458..f758dc7971 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+calibre (6.13.0+repack-2+deb12u1) bookworm; urgency=medium
+
+  * "ERROR: Unhandled exception" when opening Settings > Saving Books to disk (Closes: #1041779)
+  * Rediff patches.
+    Add reproduced error messages
+
+ -- YOKOTA Hiroshi <yokota.hgml@gmail.com>  Mon, 24 Jul 2023 20:35:33 +0900
+
 calibre (6.13.0+repack-2) unstable; urgency=medium
 
   * Update lintian overrides
diff --git a/debian/patches/0029-ERROR-Unhandled-exception-when-opening-Settings-Savi.patch b/debian/patches/0029-ERROR-Unhandled-exception-when-opening-Settings-Savi.patch
new file mode 100644
index 0000000000..b942c4aff5
--- /dev/null
+++ b/debian/patches/0029-ERROR-Unhandled-exception-when-opening-Settings-Savi.patch
@@ -0,0 +1,57 @@
+From: YOKOTA Hiroshi <yokota.hgml@gmail.com>
+Date: Sun, 9 Apr 2023 14:50:50 +0900
+Subject: "ERROR: Unhandled exception" when opening Settings > Saving Books to
+ disk (Closes: #1041779)
+
+Forwarded: not-needed
+
+Click "Preferences->Import/Export->Sending Books to disk" to
+reproduce the error.
+
+This is mostly same case of Debian bug 1034089 and 1032095.
+  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034089
+  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032095
+
+----
+calibre, version 6.13.0
+ERROR: Unhandled exception: <b>TypeError</b>:SaveTemplate.__init__() got an unexpected keyword argument 'parent'
+
+calibre 6.13  embedded-python: False
+Linux-6.3.0-2-amd64-x86_64-with-glibc2.37 Linux ('64bit', 'ELF')
+('Linux', '6.3.0-2-amd64', '#1 SMP PREEMPT_DYNAMIC Debian 6.3.11-1 (2023-07-01)')
+Python 3.11.4
+Interface language: None
+Traceback (most recent call last):
+  File "/usr/lib/calibre/calibre/gui2/preferences/main.py", line 308, in show_plugin
+    self.showing_widget = plugin.create_widget(self.scroll_area)
+                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  File "/usr/lib/calibre/calibre/customize/__init__.py", line 675, in create_widget
+    return widget(parent)
+           ^^^^^^^^^^^^^^
+  File "/usr/lib/calibre/calibre/gui2/preferences/__init__.py", line 267, in __init__
+    self.setupUi(self)
+  File "/usr/lib/calibre/calibre/gui2/preferences/saving_ui.py", line 46, in setupUi
+    self.save_template = SaveTemplate(parent=Form)
+                         ^^^^^^^^^^^^^^^^^^^^^^^^^
+TypeError: SaveTemplate.__init__() got an unexpected keyword argument 'parent'
+
+(the Preferences dialog does not open)
+---
+ src/calibre/gui2/preferences/save_template.py | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/calibre/gui2/preferences/save_template.py b/src/calibre/gui2/preferences/save_template.py
+index 82cf951..47d4510 100644
+--- a/src/calibre/gui2/preferences/save_template.py
++++ b/src/calibre/gui2/preferences/save_template.py
+@@ -18,8 +18,8 @@ class SaveTemplate(QWidget, Ui_Form):
+ 
+     changed_signal = pyqtSignal()
+ 
+-    def __init__(self, *args):
+-        QWidget.__init__(self, *args)
++    def __init__(self, parent=None):
++        QWidget.__init__(self, parent)
+         Ui_Form.__init__(self)
+         self.setupUi(self)
+         self.orig_help_text = self.help_label.text()
diff --git a/debian/patches/series b/debian/patches/series
index 651a3ce7be..ba0e98e8d3 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -26,3 +26,4 @@
 0026-Don-t-download-translation-files-from-GitHub.patch
 0027-Use-text-file-instead-of-BZip2-compressed-file.patch
 0028-TypeError-HistoryLineEdit.__init__-got-an-unexpected.patch
+0029-ERROR-Unhandled-exception-when-opening-Settings-Savi.patch

--- End Message ---
--- Begin Message --- 
Version: 12.2

The upload requested in this bug has been released as part of 12.2.

--- End Message ---
Reply to: