[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1055894: bookworm-pu: package gnome-session/43.0-1+deb12u1



Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: gnome-session@packages.debian.org, debian-gtk-gnome@lists.debian.org
Control: affects -1 + src:gnome-session

Please consider including my recent gnome-session upload in Debian 12.3.

[ Reason ]
Open text files in gnome-text-editor if gedit is not installed,
fixing https://bugs.debian.org/1055838

[ Impact ]
If not fixed, in a default task-gnome-desktop installation, plain text
files (including XML, CSS, various programming languages, etc.) default
to being opened in Libreoffice Writer (a word processor), and not in
GNOME Text Editor (a text editor) as intended.

Mitigation: if the system was upgraded from Debian 11, it will probably
still have the gedit package installed. If so, plain text files will open
in gedit by default, which is an entirely reasonable choice too.

For context, GNOME Text Editor is a simple text editor like Windows
Notepad, whereas gedit is more of a programmers' editor; which one gets to
open text files by default if both are installed is a matter of opinion
and taste, but the default on a GNOME desktop ought to be one of those two,
and certainly not a word processor.

[ Tests ]
Manually tested:
* Start from a Debian 12 VM with task-gnome-desktop and no other desktop
  environments
* Ensure gedit is *not* installed (by default, it will not be)
* echo "Hello, world!" > ~/Documents/hello.txt
* nautilus ~/Documents
* Right-click hello.txt
    * Good result: the top choice is "Open With Text Editor [Return]"
    * Bad result: the top choice is "Open With LibreOffice Writer [Return]"
* After verifying good result with the proposed gnome-session installed,
  additionally install gedit
* Right-click hello.txt
    * Good result: the top choice is "Open With gedit [Return]"
    * Bad result: anything else

[ Risks ]
Low risk: no code change, just adjusting desktop-specific defaults for
GNOME (including derivatives like Budgie and GNOME Flashback).

To minimize observable behaviour changes for systems that were already
upgraded from Debian 11 to 12, I have chosen to make gedit the default
text editor for GNOME if happens to be installed (no change for upgraded
systems), falling back to GNOME Text Editor if gedit is not present
(a fresh task-gnome-desktop installation will use this fallback in practice).
This is the opposite of my recent upload to unstable, where I made
gnome-text-editor higher priority (I think it's reasonable to expect the
default text editor to change in a major-version upgrade).

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
d/gnome-mimeapps.list: Fix the bug. It might be helpful to know that
values after the equals sign in mimeapps.list are semicolon-delimited
lists, and canonically end with a single semicolon after the last item
(but it's optional and frequently omitted, particularly for single-item
lists).

d/gbp.conf: administrivia since this is the first Debian 12 update proposed
for this package.
diffstat for gnome-session-43.0 gnome-session-43.0

 changelog           |   21 +++++++++++++++++
 gbp.conf            |    4 +--
 gnome-mimeapps.list |   62 ++++++++++++++++++++++++++--------------------------
 3 files changed, 54 insertions(+), 33 deletions(-)

diff -Nru gnome-session-43.0/debian/changelog gnome-session-43.0/debian/changelog
--- gnome-session-43.0/debian/changelog	2022-10-11 19:08:35.000000000 +0100
+++ gnome-session-43.0/debian/changelog	2023-11-13 18:34:53.000000000 +0000
@@ -1,3 +1,24 @@
+gnome-session (43.0-1+deb12u1) bookworm; urgency=medium
+
+  * Team upload
+  * d/gbp.conf: Configure branches for Debian 12 stable updates
+  * Open text files in gnome-text-editor if gedit is not installed.
+    The preinstalled text editor for Debian GNOME systems was changed
+    from gedit in Debian 11 to gnome-text-editor in Debian 12, but this
+    file was not updated to match, resulting in various plain-text formats
+    being opened in Libreoffice Writer rather than gnome-text-editor in a
+    default task-gnome-desktop installation with no further configuration.
+    To preserve current behaviour for systems that have gedit installed
+    (perhaps as a result of them having been upgraded from Debian 11 to
+    12), for all file types that were previously handled with gedit,
+    continue to use gedit by default if it happens to be installed,
+    but fall back to gnome-text-editor if gedit is not present.
+    The preference order is likely to change to gnome-text-editor as
+    default, with gedit as a fallback, in Debian 13.
+    (Closes: #1055838)
+
+ -- Simon McVittie <smcv@debian.org>  Mon, 13 Nov 2023 18:34:53 +0000
+
 gnome-session (43.0-1) unstable; urgency=medium
 
   [ Nathan Pratta Teodosio ]
diff -Nru gnome-session-43.0/debian/gbp.conf gnome-session-43.0/debian/gbp.conf
--- gnome-session-43.0/debian/gbp.conf	2022-10-11 19:08:35.000000000 +0100
+++ gnome-session-43.0/debian/gbp.conf	2023-11-13 18:34:53.000000000 +0000
@@ -1,7 +1,7 @@
 [DEFAULT]
 pristine-tar = True
-debian-branch = debian/master
-upstream-branch = upstream/latest
+debian-branch = debian/bookworm
+upstream-branch = upstream/43.x
 
 [buildpackage]
 sign-tags = True
diff -Nru gnome-session-43.0/debian/gnome-mimeapps.list gnome-session-43.0/debian/gnome-mimeapps.list
--- gnome-session-43.0/debian/gnome-mimeapps.list	2022-10-11 19:08:35.000000000 +0100
+++ gnome-session-43.0/debian/gnome-mimeapps.list	2023-11-13 18:34:53.000000000 +0000
@@ -106,37 +106,37 @@
 application/x-zoo=org.gnome.FileRoller.desktop
 application/zip=org.gnome.FileRoller.desktop
 multipart/x-zip=org.gnome.FileRoller.desktop
-text/plain=org.gnome.gedit.desktop
-text/css=org.gnome.gedit.desktop
-text/javascript=org.gnome.gedit.desktop
-text/mathml=org.gnome.gedit.desktop
-text/x-c++hdr=org.gnome.gedit.desktop
-text/x-c++src=org.gnome.gedit.desktop
-text/x-csrc=org.gnome.gedit.desktop
-text/x-chdr=org.gnome.gedit.desktop
-text/x-dtd=org.gnome.gedit.desktop
-text/x-java=org.gnome.gedit.desktop
-text/x-javascript=org.gnome.gedit.desktop
-text/x-makefile=org.gnome.gedit.desktop
-text/x-moc=org.gnome.gedit.desktop
-text/x-pascal=org.gnome.gedit.desktop
-text/x-patch=org.gnome.gedit.desktop
-text/x-perl=org.gnome.gedit.desktop
-text/x-php=org.gnome.gedit.desktop
-text/x-python=org.gnome.gedit.desktop
-text/x-sql=org.gnome.gedit.desktop
-text/x-tcl=org.gnome.gedit.desktop
-text/x-tex=org.gnome.gedit.desktop
-text/xml=org.gnome.gedit.desktop
-application/javascript=org.gnome.gedit.desktop
-application/x-cgi=org.gnome.gedit.desktop
-application/x-javascript=org.gnome.gedit.desktop
-application/x-perl=org.gnome.gedit.desktop
-application/x-php=org.gnome.gedit.desktop
-application/x-python=org.gnome.gedit.desktop
-application/x-shellscript=org.gnome.gedit.desktop
-application/xml=org.gnome.gedit.desktop
-application/xml-dtd=org.gnome.gedit.desktop
+text/plain=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/css=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/javascript=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/mathml=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-c++hdr=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-c++src=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-csrc=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-chdr=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-dtd=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-java=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-javascript=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-makefile=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-moc=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-pascal=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-patch=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-perl=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-php=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-python=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-sql=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-tcl=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/x-tex=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+text/xml=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/javascript=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/x-cgi=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/x-javascript=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/x-perl=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/x-php=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/x-python=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/x-shellscript=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/xml=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
+application/xml-dtd=org.gnome.gedit.desktop;org.gnome.TextEditor.desktop;
 application/x-font-ttf=org.gnome.font-viewer.desktop
 application/x-font-pcf=org.gnome.font-viewer.desktop
 application/x-font-type1=org.gnome.font-viewer.desktop

Reply to: