[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1050384: marked as done (bookworm-pu: package awstats/7.8-3+deb12u1)

Your message dated Sat, 09 Dec 2023 10:20:37 +0000
with message-id <83d3a3621a56b9af1e20d36ee9d390a46ab64a8a.camel@adam-barratt.org.uk>
and subject line Closing requests for updates included in 12.3 point release
has caused the Debian Bug report #1050384,
regarding bookworm-pu: package awstats/7.8-3+deb12u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1050384: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050384
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: awstats@packages.debian.org, lourisvaldo@figueredo.tec.br
Control: affects -1 + src:awstats

[ Reason ]
The package has a policy violation caused by an error in the postinst file.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037213

The bug was introduced in version 7.8-2+deb11u1 (bullseye), and I am fixing it
backwards.

[ Impact ]
If not fixed, the package will not be able to move on to testing and will be
out of trixie.

[ Tests ]
Manual tests only. I have tested following the upgrade from buster to bullseye
and then to bookworm and sid.

[ Risks ]
Trivial

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
  * debian/awstats.postinst: part of the code was moved to the awstats.preinst
    file, to avoid creating the
    /etc/logrotate.d/httpd-prerotate/awstats.dpkg-new file, and thus requiring
    user interaction when updating. See #1037213.
  * debian/awstats.preinst: created.

diffstat for awstats-7.8 awstats-7.8

 awstats.postinst |    7 -------
 awstats.preinst  |   28 ++++++++++++++++++++++++++++
 changelog        |   11 +++++++++++
 3 files changed, 39 insertions(+), 7 deletions(-)

diff -Nru awstats-7.8/debian/awstats.postinst awstats-7.8/debian/awstats.postinst
--- awstats-7.8/debian/awstats.postinst	2022-12-04 16:52:31.000000000 -0300
+++ awstats-7.8/debian/awstats.postinst	2023-08-22 22:10:53.000000000 -0300
@@ -17,13 +17,6 @@
 		chown www-data:www-data /var/cache/awstats
 		chmod 750 /var/cache/awstats
 	fi
-	# clean-up old script that didn't run
-	if [ -n "$2" ]; then
-	    if dpkg --compare-versions "$2" lt '7.8-1~'; then
-		rm -f /etc/logrotate.d/httpd-prerotate/awstats/prerotate.sh
-		rmdir /etc/logrotate.d/httpd-prerotate/awstats/ || true
-	    fi
-	fi
     ;;
 
     abort-upgrade|abort-remove|abort-deconfigure)
diff -Nru awstats-7.8/debian/awstats.preinst awstats-7.8/debian/awstats.preinst
--- awstats-7.8/debian/awstats.preinst	1969-12-31 21:00:00.000000000 -0300
+++ awstats-7.8/debian/awstats.preinst	2023-08-22 22:10:53.000000000 -0300
@@ -0,0 +1,28 @@
+#! /bin/sh
+
+set -e
+
+case "$1" in
+    upgrade)
+	# clean-up old script that didn't run
+	if [ -n "$2" ]; then
+	    if dpkg --compare-versions "$2" lt '7.8-1~'; then
+		rm -f /etc/logrotate.d/httpd-prerotate/awstats/prerotate.sh
+		rmdir /etc/logrotate.d/httpd-prerotate/awstats/ || true
+	    fi
+	fi
+    ;;
+
+    install|abort-upgrade|abort-remove|abort-deconfigure)
+
+    ;;
+
+    *)
+        echo "preinst called with unknown argument \`$1'" >&2
+        exit 0
+    ;;
+esac
+
+#DEBHELPER#
+
+exit 0
diff -Nru awstats-7.8/debian/changelog awstats-7.8/debian/changelog
--- awstats-7.8/debian/changelog	2022-12-04 16:52:31.000000000 -0300
+++ awstats-7.8/debian/changelog	2023-08-22 22:10:53.000000000 -0300
@@ -1,3 +1,14 @@
+awstats (7.8-3+deb12u1) bookworm; urgency=medium
+
+  * QA upload.
+  * debian/awstats.postinst: part of the code was moved to the awstats.preinst
+    file, to avoid creating the
+    /etc/logrotate.d/httpd-prerotate/awstats.dpkg-new file, and thus requiring
+    user interaction when updating. See #1037213.
+  * debian/awstats.preinst: created.
+
+ -- Lourisvaldo Figueredo Junior <lourisvaldo@figueredo.tec.br>  Tue, 22 Aug 2023 22:10:53 -0300
+
 awstats (7.8-3) unstable; urgency=medium
 
   * QA upload.

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 12.3

Hi,

Each of the updates discussed in these requests was included in this
morning's 12.3 bookworm point release.

Regards,

Adam

--- End Message ---
Reply to: