[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1064428: marked as done ([Britney] does not migrate new arch:all packages after initial migration of same source)

Your message dated Tue, 19 Mar 2024 20:34:38 +0100
with message-id <d04a380b-58a4-4e20-aba8-0ef0337b1981@debian.org>
and subject line Re: Bug#1064428: [Britney] does not migrate new arch:all packages after initial migration of same source
has caused the Debian Bug report #1064428,
regarding [Britney] does not migrate new arch:all packages after initial migration of same source
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1064428: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064428
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Usertags: britney

Consider the following situation:

test-src migrated after its amd64 and i386 binaries appeared. It also
has architecture-independent binaries that miraculously only showed up
after migration was complete (maybe someone hinted through the package
too early).

When this occurs, you might expect the arch:all binaries to migrate
normally or to get information from britney why that couldn't happen.
Instead, britney2 outputs the empty list in its excuses. This occurs
because ExcuseFinder._should_upgrade_srcarch explicitly skips all
architecture-independent binaries. If there are no other changes to the
source which would cause excuses output, britney says nothing. If the
package were binNMU'd, though, britney would migrate everything
including the arch:all package if it passed checks. This behavior
instability might be undesirable.

The code which skips arch:all packages dates all the way back to
britney2's original import[1], so it's not clear if it's still
load-bearing. I've been researching the reason for the explicit ignore,
but I've come up empty. For my part, I removed the descendant of the
code[2] and only hit #1064427 when running britney2-tests against it.

This may also relate to bugs like #909555, but without a reproduction
case I wouldn't hold my breath on that.

Should britney be given the ability to test arch:all packages in
ExcuseFinder by removing the block of code? If not, should it at least
give a REJECTED_CANNOT_DETERMINE_IF_PERMANENT output to help an archive
admin figure out what's going on?

I've attached a patch to britney2-tests which adds a test case to
demonstrate this situation.

Thanks,
Dalton

Attachment: 0001-New-arch-all-binary-on-migrated-source.patch
Description: Binary data


--- End Message ---
--- Begin Message --- 
Hi,

On 29-02-2024 9:25 p.m., Dalton Durst wrote:
I think that covers your questions. Thanks again for taking a look at this. I'm not sure at what point this bug should be closed now, though. When the situation is effectively prevented in Debian?
I'll close this bug now, as in Debian this shouldn't happen anymore. I also hope that I helped you a bit, but if further improvements are possible on the britney2 side, don't hesitate to provide a MR if it can be done without too much code or hacks. Clearly I'll not do the work as this isn't a Debian use-case. 

Paul

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: