[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#998155: Points users to HTTP urls when HTTPS equivalents are available



Package: reportbug
Version: 11.1.0
Severity: minor
Tags: patch
X-Debbugs-Cc: rak@debian.org

Various portions of the reportbug interface point users to HTTP sites
when HTTPS equivalents are available. For example, users are directed
to http://ftp-master.debian.org/new.html instead of
https://ftp-master.debian.org/new.html . The attached patch updates
various URLs found in the documentation.

You can apply it with:

    git am 0001-Update-URLs-to-prefer-https-where-possible.patch

-- Package-specific info:
** Environment settings:
EDITOR="vim"
PAGER="less"
DEBEMAIL="rak@debian.org"
EMAIL="rak@rak.ac"
DEBFULLNAME="Ryan Kavanagh"
NAME="Ryan Kavanagh"
INTERFACE="urwid"

** /home/rak/.reportbugrc:
reportbug_version "4.12.6"
mode expert
ui urwid
realname "Ryan Kavanagh"
email "rak@debian.org"
keyid 4E469519ED677734268FBD958F7BF8FC4A11C97A
sign gpg
no-cc
list-cc-me
mutt

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.14.0-1-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages reportbug depends on:
ii  apt                2.3.11
ii  python3            3.9.2-3
ii  python3-reportbug  11.1.0
ii  sensible-utils     0.0.17

reportbug recommends no packages.

Versions of packages reportbug suggests:
pn  claws-mail                        <none>
ii  debconf                           1.5.78
ii  debsums                           3.0.2
ii  dlocate                           1.07+nmu1
ii  emacs-bin-common                  1:27.1+1-3.1
ii  file                              1:5.39-3
ii  gnupg                             2.2.27-2
ii  opensmtpd [mail-transport-agent]  6.8.0p2-4+b1
ii  pgpgpg [pgp]                      0.13-9.1+b1
ii  python3-urwid                     2.1.2-2
pn  reportbug-gtk                     <none>
ii  xdg-utils                         1.1.3-4.1

Versions of packages python3-reportbug depends on:
ii  apt                2.3.11
ii  file               1:5.39-3
ii  python3            3.9.2-3
ii  python3-apt        2.3.0
ii  python3-debian     0.1.42
ii  python3-debianbts  3.2.0
ii  python3-requests   2.25.1+dfsg-2
ii  sensible-utils     0.0.17

python3-reportbug suggests no packages.

-- no debconf information

-- 
|)|/  Ryan Kavanagh  | 4E46 9519 ED67 7734 268F
|\|\  https://rak.ac | BD95 8F7B F8FC 4A11 C97A
From 93f9926b1340ab72f70bd0b357e23ca88a01c00f Mon Sep 17 00:00:00 2001
From: Ryan Kavanagh <rak@debian.org>
Date: Sat, 30 Oct 2021 23:25:12 -0400
Subject: [PATCH] Update URLs to prefer https where possible

---
 bin/reportbug        | 4 ++--
 reportbug/debbugs.py | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/bin/reportbug b/bin/reportbug
index 45fcd63..8d487ad 100755
--- a/bin/reportbug
+++ b/bin/reportbug
@@ -1698,7 +1698,7 @@ class UI(object):
             check_more = (mode > MODE_STANDARD)
             if check_more:
                 ewrite('Checking for newer versions at madison,' +
-                       ' incoming.debian.org and http://ftp-master.debian.org/new.html\n')
+                       ' incoming.debian.org and https://ftp-master.debian.org/new.html\n')
             else:
                 ewrite('Checking for newer versions at madison...\n')
             (avail, toonew) = checkversions.check_available(
@@ -1856,7 +1856,7 @@ class UI(object):
                     "because the package seems to lack an active maintainer, but please GO ON and "
                     "REPORT the bug, if there is one.\n"
                     "\n"
-                    "For more details, please see: http://www.debian.org/devel/wnpp/ "
+                    "For more details, please see: https://www.debian.org/devel/wnpp/ "
                 )
 
         if self.options.kudos and not self.options.debugmode:
diff --git a/reportbug/debbugs.py b/reportbug/debbugs.py
index 6a4f1df..946e7e3 100644
--- a/reportbug/debbugs.py
+++ b/reportbug/debbugs.py
@@ -55,7 +55,7 @@ SEVERITIES = {
         (Package maintainers may also designate other bugs as 'serious' and thus
         release-critical; however, end users should not do so.). For the canonical
         list of issues deserving a serious severity you can refer to this webpage:
-        http://release.debian.org/testing/rc_policy.txt .""",
+        https://release.debian.org/testing/rc_policy.txt .""",
     'important': """a bug which has a major effect on the usability
         of a package, without rendering it completely unusable to
         everyone.""",
@@ -542,7 +542,7 @@ def handle_debian_release(package, bts, ui, fromaddr, timeout, online=True, http
                         'ensure that the "old" regex does not match the "new" packages.  '
                         'Example: old="/libapt-pkg4.10|libapt-inst1.2/ libept1" '
                         'new="/libapt-pkg4.12|libapt-inst1.5|libept1.4.12/". For further '
-                        'reference, please refer to http://ben.debian.net/ .')
+                        'reference, please refer to https://debian.pages.debian.net/ben/ .')
 
         prompt = 'Please enter old binary package name of the library (or a regex matching it):'
         tfrom = ui.get_string(prompt)
@@ -665,7 +665,7 @@ itp_template = textwrap.dedent("""\
     * Package name    : %(package)s
       Version         : x.y.z
       Upstream Author : Name <somebody@example.org>
-    * URL             : http://www.example.org/
+    * URL             : https://www.example.org/
     * License         : (GPL, LGPL, BSD, MIT/X, etc.)
       Programming Lang: (C, C++, C#, Perl, Python, etc.)
       Description     : %(short_desc)s
-- 
2.33.1

Attachment: signature.asc
Description: PGP signature


Reply to: