Tags: ftbfs patch User: debian-riscv@lists.debian.org Usertags: riscv64 X-Debbugs-Cc: debian-riscv@lists.debian.org On Tue, Feb 20, 2024 at 10:57:35AM +0800, Bo YU wrote:
Package: nodejs Version: 18.19.1+dfsg-1 Severity: important Dear Maintainer, Nodejs 18.19.1+dfsg-1 has a ftbfs issue due to some test cases failed: ``` ... Failed tests: ./node /<<PKGBUILDDIR>>/test/parallel/test-runner-output.mjs ./node /<<PKGBUILDDIR>>/test/sequential/test-cpu-prof-dir-and-name.js ./node /<<PKGBUILDDIR>>/test/sequential/test-cpu-prof-name.js ... ``` Full buildd log see here: https://buildd.debian.org/status/fetch.php?pkg=nodejs&arch=riscv64&ver=18.19.1%2Bdfsg-1&stamp=1708327149&raw=0 I have flaged these tests with flaky status and confirmed it works. So could we apply it on next upload? BTW, there is some tests failed on mips64el, but I have no mips64el machine to confirm if flag these tests with flaky is okay or not like on riscv64. See #1064306. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064306 -- Regards, -- Bo YU
diff -Nru nodejs-18.19.1+dfsg/debian/changelog nodejs-18.19.1+dfsg/debian/changelog --- nodejs-18.19.1+dfsg/debian/changelog 2024-02-19 01:12:23.000000000 +0800 +++ nodejs-18.19.1+dfsg/debian/changelog 2024-02-19 18:34:13.000000000 +0800 @@ -1,3 +1,10 @@ +nodejs (18.19.1+dfsg-1.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Update riscv patch to fix ftbfs issue. (Closes: #-1) + + -- Bo YU <tsu.yubo@gmail.com> Mon, 19 Feb 2024 18:34:13 +0800 + nodejs (18.19.1+dfsg-1) unstable; urgency=medium * New upstream version 18.19.1. Closes: 1064055. diff -Nru nodejs-18.19.1+dfsg/debian/patches/riscv/flaky_tests.patch nodejs-18.19.1+dfsg/debian/patches/riscv/flaky_tests.patch --- nodejs-18.19.1+dfsg/debian/patches/riscv/flaky_tests.patch 2024-02-15 06:11:51.000000000 +0800 +++ nodejs-18.19.1+dfsg/debian/patches/riscv/flaky_tests.patch 2024-02-19 18:25:42.000000000 +0800 @@ -3,9 +3,11 @@ Author: J�my Lal <kapouer@melix.org>, Bo YU <tsu.yubo@gmail.com> Forwarded: not-yet ---- a/test/sequential/sequential.status -+++ b/test/sequential/sequential.status -@@ -65,3 +65,19 @@ +Index: nodejs-18.19.1+dfsg/test/sequential/sequential.status +=================================================================== +--- nodejs-18.19.1+dfsg.orig/test/sequential/sequential.status ++++ nodejs-18.19.1+dfsg/test/sequential/sequential.status +@@ -65,3 +65,21 @@ test-watch-mode-inspect: PASS, FLAKY [$arch==s390x] # https://github.com/nodejs/node/issues/41286 test-performance-eventloopdelay: PASS, FLAKY @@ -13,8 +15,10 @@ +[$arch==riscv64] +test-diagnostic-dir-cpu-prof: PASS, FLAKY +test-cpu-prof-worker-argv: PASS, FLAKY ++test-cpu-prof-dir-and-name: PASS, FLAKY +test-cpu-prof-exit: PASS, FLAKY +test-cpu-prof-kill: PASS, FLAKY ++test-cpu-prof-name: PASS, FLAKY +test-diagnostic-dir-cpu-prof: PASS, FLAKY +test-debugger-auto-resume: PASS, FLAKY +test-debugger-preserve-breaks: PASS, FLAKY @@ -25,9 +29,11 @@ +test-cpu-prof-dir-absolute: PASS, FLAKY + + ---- a/test/parallel/parallel.status -+++ b/test/parallel/parallel.status -@@ -150,6 +150,22 @@ +Index: nodejs-18.19.1+dfsg/test/parallel/parallel.status +=================================================================== +--- nodejs-18.19.1+dfsg.orig/test/parallel/parallel.status ++++ nodejs-18.19.1+dfsg/test/parallel/parallel.status +@@ -150,6 +150,23 @@ test-tls-write-error: PASS, FLAKY # https://github.com/nodejs/node/issues/48047 test-http-pipeline-flood: SKIP @@ -35,6 +41,7 @@ +test-fetch: PASS, FLAKY +test-net-socket-connect-without-cb: PASS, FLAKY +test-runner-inspect: PASS, FLAKY ++test-runner-output: PASS, FLAKY +test-tcp-wrap-listen: PASS, FLAKY +test-wasm-web-api: PASS, FLAKY +test-vm-timeout-escape-promise-module: PASS, FLAKY
-- Regards, -- Bo YU
Attachment:
signature.asc
Description: PGP signature