[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: gem2deb: support for building using setup.rb



Lucas Nussbaum escreveu isso aí:
> On 11/05/11 at 14:51 +0200, Vincent Fourmond wrote:
> > On 11/05/11 14:39, Lucas Nussbaum wrote:
> > > On 11/05/11 at 11:51 +0200, Vincent Fourmond wrote:
> > >>   Does anyone object to integrate a support for setup.rb directly into
> > >> gem2deb (something similar to the old cdbs class) ? That would be a
> > >> second auto build system (say, ruby-setup.rb) that users should select
> > >> explicitly (to avoid changing the build behaviour). This would allow to
> > >> keep as much code in common for the ruby build and the ruby-setup.rb
> > >> build, and keep things as consistent as possible.
> > >>
> > >>   I'd be glad to write it.
> > > 
> > > Wouldn't it risk making the gem2deb code harder to maintain?
> > 
> >   I realize I've been much too vague in my last email, so here is my
> > proposition:
> > 
> >   * the setup.rb-supporting code would be integrated directly into
> > dh_ruby.rb, making it easy to share code
> >   * it would be triggered only on a specific option, say --setup-rb
> > (that must come first of course).
> > 
> >   What do you say about that ?
> 
> That doesn't solve all the problems. You need to build for each ruby
> version, to install things at the proper places, etc.

As Lucas wrote, setup.rb seems to be really deprecated. But if Vincent
is willing to write the code, IMO go ahead and write a proposal so we
can discuss in more concrete terms.

I have only one requirement: instead of modifying the DhRuby class, please
subclass it and override the needed methods (calling super where it
makes sense), and make dh_ruby instantiate this class instead of plain
DhRuby in the case --setup-rb is passed in ARGV.

-- 
Antonio Terceiro <terceiro@softwarelivre.org>
http://softwarelivre.org/terceiro


Attachment: signature.asc
Description: Digital signature


Reply to: