[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ruby-mysql2 package is prepared



On 11/02/2012 11:26 AM, Praveen A wrote:
1. Make sure your run the tests under spec directory. You may take
ruby-orm-adapter as an example, see

http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-orm-adapter.git;a=blob;f=debian/ruby-tests.rake;h=89a753d9aca2995f6f395a1ae7cfd82b28a5d144;hb=HEAD

If tests fail because of any missing files make sure those libraries
needed to run the tests are installed and add them to build-depends.

When building the package, the tests are executed automatically. However they fail with the error

    no such file to load -- eventmachine (LoadError)

However, the .gemspec file lists it correctly with

    s.add_development_dependency 'eventmachine'

and I made sure it is installed on the machine and in the Gemfile.lock. Eventmachine is not yet a Debian package, so I guess I can't add it as Build-Depends. Does this mean that I have to make Debian packages of all the test dependencies first?

The current code is pushed to github, in case you want to have a look:

https://github.com/michaelfranzl/ruby-mysql2

Another question is: Is it okay to include Gemfile.lock to the package sources?


2. You may want to add more to the extended description. It is shown to
users who want to learn more about the package, for example when you run
apt-cache show ruby-mysql2. Add some info about what this package does
and why this is better than ruby-mysql etc.

Done.

3. Upstream provide a changelog file, consider installing it via an
override of rules file. Again see ruby-orm-adapter as an example
http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-orm-adapter.git;a=blob;f=debian/rules;h=61a35956d1fb9d48bc5d5ae99038737b78be22d5;hb=HEAD

Done.

4. In changelog file, target "unstable" release instead of "UNRELEASED"

Done.

5. Install examples using the templete given

Not sure what you mean here. Do you mean the manifest file debian/ruby-test-files.yaml?

6. Since upstream and your packaging files have the same license, you
need to specify the full text of the license only once. See
http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-orm-adapter.git;a=blob;f=debian/copyright;h=335cca71dc4319394dc4b095f6fb9db94aa676cc;hb=HEAD

Done.

7. Add some descriptions to your patch, it currently has a generated
template

Done.

8. I suggest you re-import your package with --pristine-tar option to
git-import-dsc command. Also you need to remove the tag debian/0.3.11-1
(your sponsor will add this tag when it is ready for upload).

Done.

9. I suggest you request membership at
https://alioth.debian.org/projects/pkg-ruby-extras/ as all team packages
are maintained there.

Have created an account.

Thanks,
Michael


Reply to: