Re: RFS: ruby-aws-sdk - closes ITP
Hi Cédric,
El Lunes, 8 de septiembre de 2014 16:25:05 Cédric Boutillier escribió:
> Here is a quick review:
>
> I think that it would better to place the files endpoints.json and
> ca-bundle.crt under /usr/share/ruby-aws-sdk. This requires to adapt
> use-correct-path-for-bundled-certificate and to add a patch for
> lib/aws/core/endpoints.rb
>
> Also, the pristine-tar branch contains a tar ball, but with the wrong
> name (should be ruby-aws-sdk_1.43.2.orig.tar.gz, not
> aws-sdk_1.43.2.orig.tar.gz)
>
> There is a newer upstream version (1.52.0 instead of 1.43.2). Do you
> want to update your packaging for this new version?
>
> Otherwise, looks fine to me.
All fixed :)
Thanks for the review !
Cheers
David
Reply to: