Re: Request for sponsorship: ruby-elasticsearch, ruby-elasticsearch-api, ruby-elasticsearch-transport
Cédric wrote:
> On Wed, Sep 17, 2014 at 01:08:20AM +0000, Potter, Tim (Cloud Services)
>wrote:
> > I spent a fair while trying to get the test suite going, and it appears
> > that it¹s necessary to have a elasticsearch server running on port 9200
> > for the tests to succeed. That doesn¹t sound like something that
>should be
> > happening as part of a package build.
>
> > I also needed to package up about a dozen extra Ruby gems just to get
>the
> > test suites for ruby-elasticsearch* running without import errors. Not
> > sure it¹s worth the extra effort, but if that¹s policy then I can try
> > and get things working and submit them for upload.
>
> If there is a subset of tests (some unit tests?) that could run without
> the elasticsearch server, you may try to run only those. If you manage
> to package the dozen of gems, you could (maybe as a middle term goal) to
> run the full test suite with autopkgtest.
I'll take a look at this. I must admit not diving too deeply into the
tests
after seeing that they fail trying to make a network connection.
> The repository seems to miss the pristine-tar branch.
Aargh - is there any way to recreate this after the fact? Apparently you
have to pass in the --pristine-tar option when running gbp import-dsc,
which
I didn't do.
> Since you seem to need dependency on ruby-elasticsearch-* for
> ruby-elasticsearch with the same version, you can use (=
> ${source:Version}) for the version restriction in the dependency instead
> of typing manually the Debian version (which is also error-prone).
Thanks - fixed.
> And what about elastic-extensions? Is there a reason not to make a
> binary package out of it?
As far as I can tell the extensions package is only used for running the
(network connection requiring) tests. Will look more closely at this.
Also it pulls in the other dozen or so unpackaged gems. (-:
> For the documentation, since every subdirectory ships its own README,
> you will need a debian/ruby-elasticsearch*.docs for each binary package.
> Ship also the examples subdirectory by mentioning it in a
> debian/ruby-elasticsearch.examples file.
Fixed.
> The short description shouldn't begin with an uppercase letter with no
> reason. Could you fix the one for ruby-elasticsearch-transport?
Also fixed.
Thanks again!
Tim Potter
Cloud Systems Engineer
HP Cloud Services
timothy.potter@hp.com
M +61 419 749 832
Hewlett-Packard Australia Pty Ltd
This e-mail may contain confidential and privileged material for the sole
use of the intended recipient. Any review, use, distribution or disclosure
by others is strictly prohibited. If you are not the intended recipient
(or authorised to receive for the recipient), please contact the sender by
reply e-mail and delete all copies of this message.
Reply to: