[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#818237: Re: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)



* Antonio Terceiro <terceiro@debian.org> [160401 16:34]:
> On Fri, Apr 01, 2016 at 02:22:14PM +0200, Christian Hofstaedtler wrote:
> > ...

> I have one question on the patch though:
> 
> > diff --git a/lib/vagrant/bundler.rb b/lib/vagrant/bundler.rb
[..]
> >        # Reset the all specs override that Bundler does
> >        old_all = Gem::Specification._all
> > -      Gem::Specification.all = nil
> >  
> >        # /etc/gemrc and so on.
> >        old_config = nil
> > @@ -286,6 +285,8 @@ module Vagrant
> >        end
> >        Gem.configuration = NilGemConfig.new
> >  
> > +      Gem::Specification.reset
> > +
> 
> any specific reason to put this call down here, instead of exactly in
> the place of the broken one?

I -guessed- that Gem.configuration = NilGemConfig.new may reset
Gem.(pre|post)_reset_hooks, but upon closer inspection it doesn't
appear to do that.

As such, no good reason to move it.

-- 
 ,''`.  Christian Hofstaedtler <zeha@debian.org>
: :' :  Debian Developer
`. `'   7D1A CFFA D9E0 806C 9C4C  D392 5C13 D6DB 9305 2E03
  `-


Reply to: