Re: Looking for feedback on a recent upload

[Lumin <cdluminate@gmail.com>]

Hi Thomas,

Glad to see you came back to maintain this package.
This package gives an overview of your package status in Debian:

  https://tracker.debian.org/pkg/toulbar2

> Would it be possible to have any feedback on this:
> 
>     - is it packaging fine on salsa (am I finished) ?

I indeed spotted something that doesn't match the debian-science
conventions:

1. Git repository layout in question

   File debian/source/format writes "3.0 (quilt)", so the master
   branch should hold the "packaging commits" instead of the
   "upstream commits". By the way, please always keep the
   "upstream" and "pristine-tar" branches up to date. In order
   to achieve that, you can use this command when importing
   a new upstream verison:
   
   │
   │ $ gbp import-orig --pristine-tar XXX_YYY.orig.tar.gz
   │

   More details can be found in Debian Science Team Policy[1].

2. "watch" file not working.

   We often use "uscan"[2] to conveniently obtain an tarball from upstream.
   However the present watch file doesn't work anymore. Try to fix it
   like this:

   │
   │ version=4
   │ opts="filenamemangle=s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%toulbar2-$1.tar.gz%" \
   │     https://github.com/toulbar2/toulbar2/tags \
   │     (?:.*?/)?v?(\d[\d.]*)\.tar\.gz debian uupdate
   │

   I can obtain a tarball via this watch file.

3. Reproducibility problem.

   With the upstream tarball downloaded by uscan. The package doesn't
   build because the contents of git HEAD doesn't match with the
   tarball.

   Actually this makes it harder for the others to review your work :-)

4. Policy version and debhelper compatibility level.

   debian/control: "Standards-Version: 3.9.8"
   This version is quite old. Please check the policy check list [3]
   and upgrade it.

   Apart from that, the compat level is 9. This is just a
   recommend-to-fix. Have a look at manpage debhelper(7) and check
   the "COMPATIBILITY LEVELS" part if you are interested in this.

5. Failed to build from source.

   I changed the source format to native[4] and tried to build it
   in docker. However it failed to build.

   │
   │         Start 200: Phase2_10_1.bep_2
   │ 200/200 Test #200: Phase2_10_1.bep_2 ..................................   Passed    0.01 sec
   │ 
   │ 99% tests passed, 1 tests failed out of 200
   │ 
   │ Total Test time (real) =  43.65 sec
   │ 
   │ The following tests FAILED:
   │ 	 39 - Phase1_Toulbar_enum/latin0 (Failed)
   │ Errors while running CTest
   │ make[1]: *** [Makefile:155: test] Error 8
   │ make[1]: Leaving directory '/home/whalebuilder/toulbar2/obj-x86_64-linux-gnu'
   │ dh_auto_test: cd obj-x86_64-linux-gnu && make -j1 test ARGS\+=-j1 returned exit code 2
   │ make: *** [debian/rules:3: build] Error 2
   │ dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
   │ debuild: fatal error at line 1152:
   │ dpkg-buildpackage -rfakeroot -us -uc -ui -j4 failed
   │

   Currently I have no idea about it at all. The problem is produced
   from git HEAD[5] of the salsa repo.

6. You have an RC bug.

   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831148

   It is FTBFS with GCC6. Since the default compiler is GCC7 now,
   Does it reporduce with GCC-7?
   If the bug doesn't exist anymore, you can close it with a changelog
   entry like this:

   │
   │ * import upstream release 1.0.0 . (Closes: #XXXXXX)
   │

7. Please try to build it on Debian sid/unstable.

   Lintian didn't report anything about the standards version, which
   indicates that your building system is Debian stable. It ships
   an ancient lintian.

   A package can be built for Debian unstable with one of the following:

      Docker, sbuild, pbuilder, schroot

   I can see several lintian warnings and errors from the source package
   check. Please run lintian like this:

   │
   │ $ lintian -EviI --pedantic XXX_YYY.changes
   │

   And fix those Errors and Warnings.

>     - can I test or have direct feedback on this by myself?

8. http://debomatic-amd64.debian.net/

   If you ask, people in the list would be happy to help you upload
   if you don't have access to it.


We can continue the discussion when a reproducible source tarball
becomes available.


[1] https://science-team.pages.debian.net/policy/
[2] "uscan" comes from "devscripts" package.
[3] https://www.debian.org/doc/debian-policy/#document-upgrading-checklist
[4] This is dirty hack. Don't do this.
[5] 905ff12b91d39c4e690d232441b3a39d9d080b4f