Bug#715194: openssh-server: ship systemd unit files
On Mon, Jul 08, 2013 at 06:29:42PM +0200, Sven Joachim wrote:
> On 2013-07-06 23:23 +0200, Colin Watson wrote:
> > I'd consider applying a patch if it were complete (i.e. handled all the
> > packaging side of things as well). I'm unlikely to get around to this
> > otherwise.
>
> Attached is a patch that adapts the Fedora unit files[2] to Debian
> customs,
Thanks, I'll look into these for my next upload.
> e.g. the units test for /etc/ssh/sshd_not_to_be_run and even check
> /dev/null (is that really necessary?).
Yes. Although sshd_not_to_be_run is deprecated, bear in mind that
people may be upgrading from old systems and expect their configuration
still to work. I see no reason why a change of init system should
affect that. :-) As for /dev/null, well, I never managed to track down
what was zapping it (#369964 et al) but I would rather keep a small
amount of cruft around to check for that than have to deal with confused
people filing bug reports.
> diff -Nru openssh-6.2p2/debian/openssh-server.ssh.service openssh-6.2p2/debian/openssh-server.ssh.service
> --- openssh-6.2p2/debian/openssh-server.ssh.service 1970-01-01 01:00:00.000000000 +0100
> +++ openssh-6.2p2/debian/openssh-server.ssh.service 2013-07-08 13:36:53.000000000 +0200
> @@ -0,0 +1,14 @@
> +[Unit]
> +Description=OpenSSH server daemon
> +After=syslog.target network.target auditd.service
> +ConditionPathExists=!/etc/ssh/sshd_not_to_be_run
> +
> +[Service]
> +EnvironmentFile=/etc/default/ssh
> +ExecStartPre=/usr/bin/test -c /dev/null
Does systemd really not support looking up command names on some
reasonable $PATH? That's a timebomb waiting to explode underneath
somebody.
> +ExecStart=/usr/sbin/sshd -D $SSHD_OPTS
(This one is actually necessary, of course, due to sshd's re-exec
arrangements.)
Cheers,
--
Colin Watson [cjwatson@debian.org]
Reply to: