[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#659746: marked as done (tex-gyre: use dh_installdeb maintscript support)

Your message dated Wed, 07 Mar 2012 03:23:36 +0000
with message-id <E1S57TU-0007p4-Aj@franck.debian.org>
and subject line Bug#659746: fixed in tex-gyre 2.004.1-3
has caused the Debian Bug report #659746,
regarding tex-gyre: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659746: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659746
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: tex-gyre
Version: 2.004.1-2.1
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before tex-gyre.
This seems generally undesirable; it would be better to enforce a single
code path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you could remove some of your handwritten maintainer scripts
entirely.  Here's a patch.  Note that I also corrected the previous
NMUer's misunderstanding of the version parameter to
dpkg-maintscript-helper.

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

reverted:
--- tex-gyre-2.004.1/debian/postrm
+++ tex-gyre-2.004.1.orig/debian/postrm
@@ -1,9 +0,0 @@
-#! /bin/sh
-
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-gyre.hints 2.004.1-3 -- "$@"
-fi
-
-#DEBHELPER#
diff -u tex-gyre-2.004.1/debian/control tex-gyre-2.004.1/debian/control
--- tex-gyre-2.004.1/debian/control
+++ tex-gyre-2.004.1/debian/control
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian TeX maintainers <debian-tex-maint@lists.debian.org>
 Uploaders: Norbert Preining <preining@debian.org>
-Build-Depends: debhelper (>= 5.0.35)
+Build-Depends: debhelper (>= 8.1.0~)
 Build-Depends-Indep: tex-common (>= 1.18)
 Standards-Version: 3.8.3
 Vcs-Svn: svn://svn.debian.org/svn/debian-tex/tex-gyre/trunk
@@ -13,6 +13,7 @@
 Package: tex-gyre
 Section: tex
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Description: scalable PostScript and OpenType fonts based on URW Fonts
  The TeX Gyre project, following the Latin Modern project, aims at providing
diff -u tex-gyre-2.004.1/debian/preinst tex-gyre-2.004.1/debian/preinst
--- tex-gyre-2.004.1/debian/preinst
+++ tex-gyre-2.004.1/debian/preinst
@@ -10,7 +10,2 @@
 
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-gyre.hints 2.004.1-3 -- "$@"
-fi
-
 #DEBHELPER#
reverted:
--- tex-gyre-2.004.1/debian/postinst
+++ tex-gyre-2.004.1.orig/debian/postinst
@@ -1,9 +0,0 @@
-#! /bin/sh
-
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-gyre.hints 2.004.1-3 -- "$@"
-fi
-
-#DEBHELPER#
only in patch2:
unchanged:
--- tex-gyre-2.004.1.orig/debian/maintscript
+++ tex-gyre-2.004.1/debian/maintscript
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-gyre.hints 2.004.1-2

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: tex-gyre
Source-Version: 2.004.1-3

We believe that the bug you reported is fixed in the latest version of
tex-gyre, which is due to be installed in the Debian FTP archive:

tex-gyre_2.004.1-3.diff.gz
  to main/t/tex-gyre/tex-gyre_2.004.1-3.diff.gz
tex-gyre_2.004.1-3.dsc
  to main/t/tex-gyre/tex-gyre_2.004.1-3.dsc
tex-gyre_2.004.1-3_all.deb
  to main/t/tex-gyre/tex-gyre_2.004.1-3_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659746@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Norbert Preining <preining@debian.org> (supplier of updated tex-gyre package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 05 Mar 2012 09:33:53 +0900
Source: tex-gyre
Binary: tex-gyre
Architecture: source all
Version: 2.004.1-3
Distribution: experimental
Urgency: low
Maintainer: Debian TeX maintainers <debian-tex-maint@lists.debian.org>
Changed-By: Norbert Preining <preining@debian.org>
Description: 
 tex-gyre   - scalable PostScript and OpenType fonts based on URW Fonts
Closes: 566986 649830 659746
Changes: 
 tex-gyre (2.004.1-3) experimental; urgency=low
 .
   * fix dangling symlink after the renaming qzcri -> qzcmi (Closes: #566986)
   * ack NMU (Closes: #649830)
   * build from tex-common v3 for TL2012, remove updmap.d conffile
   * build-dep on tex-common >= 3
 .
   [ Hilmar Preuße ]
   * Use maintscript support in dh_installdeb rather than writing out
     dpkg-maintscript-helper commands by hand. Thanks to Colin Watson
     (Closes: #659746)
Checksums-Sha1: 
 27d6783c3e1d1af8920d5742f5371f1183d14f41 1314 tex-gyre_2.004.1-3.dsc
 0db166a7fc6e58b524f9496a0685face14692781 10202 tex-gyre_2.004.1-3.diff.gz
 9b20e5fcc5288c68ab46f36e6e517a2f73b621af 16089860 tex-gyre_2.004.1-3_all.deb
Checksums-Sha256: 
 b22fe5eb4e48d32a5b1ad4f01bfbb422d615d63cd87298e0b4a50438d4953e81 1314 tex-gyre_2.004.1-3.dsc
 f92419fcf62afd6bef2573448bc2cd27a2965b0c2efeb1aa07965ff511b877e0 10202 tex-gyre_2.004.1-3.diff.gz
 a06494c7e4f57067e79aedb1ad5a32c54d21632df7136d7e71b6b8e1d5d792c2 16089860 tex-gyre_2.004.1-3_all.deb
Files: 
 cf45c8fa6db757ffb509cd3d65ad3206 1314 tex optional tex-gyre_2.004.1-3.dsc
 744b628ada2d513f68c180b71b4d440c 10202 tex optional tex-gyre_2.004.1-3.diff.gz
 027961c0cbc0fa40ae562d2f6c4ac8d2 16089860 tex optional tex-gyre_2.004.1-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iD8DBQFPVCvd0r9KownFsJQRAj0jAJ49w4THV1tuCTDRTF+5cZnmidjjgwCfd3TX
tamFfa53whbCdrWIZv15Riw=
=aN1K
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: