also sprach Ben Finney <ben+debian@benfinney.id.au> [2009.06.09.1735 +0200]: > I would of course appreciate any constructive feedback resulting from > inspection of the package. quick points: debian/control: s/^VCS-/Vcs-/ I think, but not sure it matters. Same for s/bzr/Bzr/ Description sa bit too short for my taste, maybe mention VCS? debian/copyright: why are the two GPL2+ boilerplate texts of different lengths? debian/get-orig-source: VCS_URL is file:/ I've never used pristine-tar in this way Otherwise it looks good. Generally, I don't like set-root, I think that should be called init. Also, why doesn't be commit after it takes an action? I think it's kinda weird that I have to commit after creating a new bug. I think this is ready for upload, but it would be nice if the above issues could be addressed. Thanks for your work! -- .''`. martin f. krafft <madduck@d.o> Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduck http://vcs-pkg.org `- Debian - when you have better things to do than fixing systems
Attachment:
digital_signature_gpg.asc
Description: Digital signature (see http://martin-krafft.net/gpg/)