[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1017088: ITP: c4core -- library of low-level C++ utilities, written with low-latency projects in mind



Hi all,

On Mon, 31 Oct 2022 21:46:18 +0900 Daichi Fukui <a.dog.will.talk@akane.waseda.jp> wrote:
> Hi Punit-san,
>
> Thanks for a reply.
>
> On Tue, 25 Oct 2022 at 06:46, Punit Agrawal <punitagrawal@gmail.com> wrote:
>
> > Hi Fukui-san,
> >
> > Daichi Fukui <a.dog.will.talk@akane.waseda.jp> writes:
> >
> > > Hello Debian Developers,
> > >
> > > On Sat, 13 Aug 2022 13:03:16 +0000 Fukui Daichi <
> > a.dog.will.talk@akane.waseda.jp> wrote:
> > >> Package: wnpp
> > >> Severity: wishlist
> > >> Owner: Fukui Daichi <a.dog.will.talk@akane.waseda.jp>
> > >> X-Debbugs-Cc: debian-devel@lists.debian.org,
> > a.dog.will.talk@akane.waseda.jp
> > >>
> > >> * Package name    : c4core
> > >>   Version         : 0.1.9
> > >>   Upstream Author : Joao Paulo Magalhaes <dev@jpmag.me>
> > >> * URL             : https://github.com/biojppm/c4core
> > >> * License         : MIT
> > >>   Programming Lang: C++
> > >>   Description     : library of low-level C++ utilities, written with
> > low-latency projects in mind
> > >>
> > >> Rationale:
> > >>    rapidyaml [0] depends on this utility.
> > >>    Moreover, jsonnet [1] depends on rapidyaml.
> > >>
> > >>    [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003397
> > >>    [1] https://tracker.debian.org/pkg/jsonnet
> > >>
> > >> Maintenance plan:
> > >>    Because I am a novice in debian packaging, I would like to
> > >>    ask for someone who can review my upload. I need a sponsor too.
> > >>
> > >>
> > >
> > > As mentioned in a different bugreport [0], c4core depends on
> > biojppm/cmake, debugbreak, and fast_float.
> > > To meet the dependency, we're now preparing for uploading debugbreak and
> > fast_float [1][2].
> > >
> > > As for biojppm/cmake, it looks like this software is used for the
> > author's project only.
> > > This makes me wonder if it is really reasonable to package biojppm/cmake.
> > > It is technically possible to package it but it could end up with no
> > other packages depending on the packaged biojppm/cmake than c4core.
> > > To make a clear decision, I would like to ask for your opinion on this
> > issue.
> > >
> > > If you are interested, see also a discussion [3] similar to this one.
> >
> > I'm not familiar with Debian convention regarding this so please take
> > any comments here with a pinch of salt.
> >

I've been trying to use the newly added libfast-float-dev [0] and debugbreak [1] packages to replace some embedded header files of c4core.

While looking at libfast-float-dev, I came up with the following issue.
Let me explain what's going on.

c4core uses fast_float.hpp and fast_float_all.h many times in its source code, 
so first I tried to simply replace them with the header files which the libfast-float-dev package provides.
Note that the fast_float.hpp is effectively a wrapper for fast_float_all.h.
However, it seems a bit difficult to use the libfast-float-dev package for replacing fast_float.hpp and fast_float_all.h.
This is because fast_float_all.h was apparently created with fast_float/script/amalgamate.py as a single header file, 
which the libfast-float-dev package does not provide as such.

Taking the situation above into account, I would like to propose the following options to address this issue.

Options:

(a) Use fast_float.hpp and fast_float_all.hpp, both of which are already embedded in c4core; 
we don't use libfast-float-dev for replacing them.

(b) Use the fast_float pacakge - use amalgamate.py to generate a single header like fast_float_all.hpp,
add it to the fast_float package, then replace fast_float_all.hpp with the one which the package provides

I would appreciate it if you help me decide which option to take or if you share other options, if any.
What do you think?

FYI, there are no issues when it comes to using debugbreak for c4core.

[0] https://packages.debian.org/bookworm/libfast-float-dev
[1] https://packages.debian.org/bookworm/debugbreak

Best,
Fukui


Reply to: